Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): subscriptions rtf support #837

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

sundersc
Copy link
Contributor

Description of changes

This PR enables subscription runtime filtering.

  • Adds filter argument to subscriptions to provide server side filtering.
  • Supports subscriptions with multiple owners auth rules.

Description of how you validated changes

  • yarn test
  • manual test
  • e2e test

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner September 28, 2022 19:20
@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2022

This pull request fixes 1 alert when merging 738db70 into 97511a4 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2022

This pull request fixes 1 alert when merging a85948b into 97511a4 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2022

This pull request fixes 1 alert when merging cf54473 into 97511a4 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@codecov-commenter
Copy link

Codecov Report

Merging #837 (cf54473) into main (c0d92c7) will increase coverage by 0.06%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   63.27%   63.33%   +0.06%     
==========================================
  Files         282      282              
  Lines       18356    18367      +11     
  Branches     4453     4457       +4     
==========================================
+ Hits        11615    11633      +18     
+ Misses       6131     6125       -6     
+ Partials      610      609       -1     
Impacted Files Coverage Δ
...plify-graphql-auth-transformer/src/utils/schema.ts 94.65% <ø> (ø)
...ql-auth-transformer/src/resolvers/subscriptions.ts 91.42% <75.00%> (-8.58%) ⬇️
...l-auth-transformer/src/graphql-auth-transformer.ts 94.81% <100.00%> (ø)
...-graphql-auth-transformer/src/resolvers/helpers.ts 100.00% <0.00%> (+8.92%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alharris-at alharris-at merged commit 99caa22 into aws-amplify:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants