Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate data forced updates into api category package #899

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Oct 18, 2022

Description of changes

  • Migrate data forced updates into api category package.
  • Expose a new method called checkForcedUpdates which will be exposed over the plugin bridge.
  • No functional changes, just lifted and shifted code.

CLI Update PR: aws-amplify/amplify-cli#11212

Issue #, if available

N/A

Description of how you validated changes

Build/unit tests pass, no other changes in here.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 1 alert when merging a71fcab into 64a9c0e - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Oct 19, 2022

This pull request introduces 1 alert when merging 0e1ef17 into 64a9c0e - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@codecov-commenter
Copy link

Codecov Report

Merging #899 (0e1ef17) into main (64a9c0e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   63.30%   63.30%           
=======================================
  Files         282      282           
  Lines       18377    18377           
  Branches     4461     4461           
=======================================
  Hits        11634    11634           
  Misses       6132     6132           
  Partials      611      611           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alharris-at alharris-at merged commit 00d03a4 into main Oct 19, 2022
@alharris-at alharris-at deleted the force-push-update branch October 19, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants