Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: converted notifications category from JS to TS #11025

Merged
merged 2 commits into from Sep 21, 2022

Conversation

lazpavel
Copy link
Contributor

Description of changes

  • converts notifications category from JS to TS

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazpavel lazpavel requested a review from a team as a code owner September 19, 2022 22:18
@lgtm-com
Copy link

lgtm-com bot commented Sep 19, 2022

This pull request fixes 2 alerts when merging df2b27e into ac31ec0 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2022

This pull request fixes 2 alerts when merging 24f7b23 into ac31ec0 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2022

This pull request fixes 2 alerts when merging 4c65fa7 into ac31ec0 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #11025 (4c65fa7) into dev (6ab0c99) will increase coverage by 1.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##              dev   #11025      +/-   ##
==========================================
+ Coverage   48.19%   49.22%   +1.02%     
==========================================
  Files         670      663       -7     
  Lines       32446    31779     -667     
  Branches     6598     6447     -151     
==========================================
+ Hits        15638    15643       +5     
+ Misses      15188    14650     -538     
+ Partials     1620     1486     -134     
Impacted Files Coverage Δ
packages/amplify-cli-core/src/cliConstants.ts 100.00% <ø> (ø)
packages/amplify-cli-core/src/types.ts 100.00% <ø> (ø)
...fy-category-notifications/src/validate-filepath.ts 33.33% <33.33%> (ø)
...-category-notifications/src/apns-cert-p8decoder.ts 40.00% <40.00%> (ø)
...category-notifications/src/apns-cert-p12decoder.ts 14.92% <62.50%> (ø)
...amplify-category-notifications/src/channel-APNS.ts 64.42% <88.46%> (ø)
...ify-category-notifications/src/apns-cert-config.ts 88.88% <88.88%> (ø)
.../amplify-category-notifications/src/channel-FCM.ts 73.17% <92.85%> (ø)
...lify-category-notifications/src/apns-key-config.ts 91.66% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

danielleadams
danielleadams previously approved these changes Sep 20, 2022
akshbhu
akshbhu previously approved these changes Sep 20, 2022
Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor modifications are added as comments

@lazpavel lazpavel dismissed stale reviews from akshbhu and danielleadams via a798fd6 September 20, 2022 19:08
@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2022

This pull request fixes 2 alerts when merging a798fd6 into 262276a - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

akshbhu
akshbhu previously approved these changes Sep 20, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2022

This pull request fixes 2 alerts when merging 90326ad into 262276a - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

Copy link
Contributor

@awsluja awsluja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall solid refactor; just added some nit picks and some questions

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2022

This pull request fixes 2 alerts when merging 07813a8 into 262276a - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lazpavel lazpavel merged commit b67fb81 into aws-amplify:dev Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants