Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overriden mock resource outputs are respected in amplifyconfiguration #13274

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented Sep 27, 2023

Description of changes

Fixes an issue with mocking where the local GraphQL endpoint and API key are not reflected in the amplifyconfiguration.json file when customer runs amplify mock api in iOS/Android projects. Refer to discord customer report for more information.

image

Issue #, if available

Description of how you validated changes

Added unit tests, check in iOS,Android samples.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team as a code owner September 27, 2023 19:35
@@ -1,4 +1,4 @@
const configHelper = require('../../amplify-frontend-android/lib/amplify-config-helper');
Copy link
Contributor Author

@phani-srikar phani-srikar Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have NOT been testing iOS config generator BUT Android all this time from the iOS frontend plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants