fix: s3 resource fails in amplify push for too-long bucket name #13802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0618
reviewed
Jul 2, 2024
| @@ -1,8 +1,8 @@ | |||
| module.exports = (value) => { | |||
| let isValid = typeof value === 'string' && value.length >= 3 && value.length <= 63 && /^[a-z0-9.-]*$/.test(value); | |||
| let isValid = typeof value === 'string' && value.length >= 3 && /^[a-z0-9.-]*$/.test(value); | |||
There was a problem hiding this comment.
Thanks for contributing!
Unfortunately, S3 has a limitation to the bucket names
The bucket name can be between 3 and 63 characters long, and can contain only lower-case characters, numbers, periods, and dashes.
Please check out here https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-trail-naming-requirements.html
There was a problem hiding this comment.
Apologies for not looking into that first, You think the issue should be closed since bucket name rules dont allow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix: Remove 63 character length validation
Thanks @ykethan
Issue #, if available
#13364
Description of how you validated changes
Added a unit test for it
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.