Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support choosing AWS authentication flow when admin UI is enabled #6433

Merged
merged 22 commits into from
Feb 2, 2021
Merged

fix: support choosing AWS authentication flow when admin UI is enabled #6433

merged 22 commits into from
Feb 2, 2021

Conversation

jhockett
Copy link
Contributor

@jhockett jhockett commented Jan 19, 2021 •
edited by nikhname

Issue #, if available:
aws-amplify/amplify-studio#32
#6437

Description of changes:
New prompt for choosing an authentication flow. This allows customers to choose a profile or supply access keys even if admin UI is enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 19, 2021 •
edited

Codecov Report

Merging #6433 (949533e) into master (1e115c5) will decrease coverage by 0.26%.
The diff coverage is 9.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6433      +/-   ##
==========================================
- Coverage   57.27%   57.00%   -0.27%     
==========================================
  Files         479      481       +2     
  Lines       21712    21838     +126     
  Branches     4315     4354      +39     
==========================================
+ Hits        12435    12449      +14     
- Misses       8396     8508     +112     
  Partials      881      881
Impacted Files Coverage Δ
...lify-provider-awscloudformation/src/admin-login.ts 19.23% <0.00%> (ø)
...provider-awscloudformation/src/aws-utils/aws-s3.ts 10.09% <0.00%> (ø)
...der-awscloudformation/src/configuration-manager.ts 6.11% <9.00%> (-0.52%) ⬇️
...vider-awscloudformation/src/utils/admin-helpers.ts 19.23% <11.11%> (-4.46%) ⬇️
...tion/src/question-flows/configuration-questions.ts 70.00% <100.00%> (+3.33%) ⬆️
...-awscloudformation/src/utils/admin-login-server.ts 16.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e115c5...edff2dc. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2021

This pull request introduces 1 alert when merging 3aeae05 into 4f35e08 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@jhockett jhockett force-pushed the credentials-update branch 3 times, most recently from 2ddf6f0 to 2aa509c Compare January 25, 2021 06:20
@nikhname nikhname mentioned this pull request Jan 25, 2021
Closed
@nikhname nikhname linked an issue Jan 25, 2021 that may be closed by this pull request
"Failed to fetch Amplify Admin credentials init failed" on new project #6437
Closed
@jhockett jhockett marked this pull request as ready for review January 27, 2021 19:31
@jhockett jhockett requested a review from a team as a code owner January 27, 2021 19:31
@jhockett
fix: configuration-manager redesign [WIP]
f126db3
@jhockett
fix: optional field
07c0168
@jhockett
fix: acquire admin credentials properly on env add
de3db4b
@jhockett
refactor: simplify and refactor admin credential aquisition
c85f629
@jhockett
fix: typo, remove unused imports
ad29c54
@jhockett
fix: update e2e helpers, update auth-types
3ddb4a6
@jhockett
fix: update refresh token on refresh
287491e
@jhockett
fix: supplying access keys on init
1548e0e
@jhockett
fix: overwriting region, code formatting
7e6815c
@jhockett
fix: handle undefined case in object destructuring
5545594
@jhockett
chore: add missing type
2b3888a
@jhockett
fix: use general config for env vars
d3239a7
@jhockett
refactor: change function name for consistency
250475b
@jhockett
fix: don't assume env var credential usage, broken e2e tests
3e0cf7d
@jhockett
fix: account for --yes flag, add types
6959668
@jhockett
fix: determining accessKey behavior, update tests
b614df9
@jhockett
test: fix amplify pull helper
8d322d5
kaustavghosh06
kaustavghosh06 reviewed Feb 2, 2021
View reviewed changes
packages/amplify-provider-awscloudformation/src/aws-utils/aws-pinpoint.js
@@ -39,7 +39,7 @@ async function getConfiguredPinpointClient(context, category, action, envName) {
// ignore missing config
}
category = category || 'missing';
action = action || 'missing';
action = action || ['missing'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a part of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an unrelated fix for a minor bug I stumbled upon when working on this

@SwaySway SwaySway merged commit 3bf56a8 into aws-amplify:master Feb 2, 2021
@kaustavghosh06 kaustavghosh06 mentioned this pull request Feb 3, 2021
Closed
@jhockett jhockett mentioned this pull request Feb 23, 2021
Merged
@jhockett jhockett deleted the credentials-update branch February 24, 2021 00:18
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edwardfoyle edwardfoyle edwardfoyle left review comments

@kaustavghosh06 kaustavghosh06 kaustavghosh06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Failed to fetch Amplify Admin credentials init failed" on new project
4 participants
@jhockett @kaustavghosh06 @edwardfoyle @SwaySway