-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amplify-category-auth): add HostedUI custom domain in metadata #6499
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6499 +/- ##
========================================
Coverage 57.28% 57.28%
========================================
Files 479 479
Lines 21695 21695
Branches 4096 4312 +216
========================================
Hits 12429 12429
+ Misses 8405 8385 -20
- Partials 861 881 +20
Continue to review full report at Codecov.
|
Any ETA on when this can be merged? This would be great and it looks like the work is already done... |
bump? |
@edwardfoyle any news on this ? |
Hey @vic-blt, would you be interested in continuing to work on this PR? If so, please rebase this onto dev by running git rebase dev. We will help you with getting this PR to the finish line 🏁 |
45b3caa
to
9271ca2
Compare
HostedUIDomain equals to either the domain prefix or the custom domain defined in the user pool. However we need to differentiate a custom domain from a domain prefix for the config put in aws-exports.js fix aws-amplify#1880
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #6499 +/- ##
===========================================
+ Coverage 0.00% 47.58% +47.58%
===========================================
Files 1296 843 -453
Lines 149743 38370 -111373
Branches 1296 7852 +6556
===========================================
+ Hits 0 18257 +18257
+ Misses 148447 18481 -129966
- Partials 1296 1632 +336
... and 1275 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@evcodes I rebased onto dev. |
Thank you, I am running the changes through our e2e test suite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thank you!
@evcodes @goldbez |
Fix #1880
HostedUIDomain equals to either the domain prefix or the custom domain defined in the user pool.
However we need to differentiate a custom domain from a domain prefix for the config put in aws-exports.js
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.