fix: carry existing container secret config over #7224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
requested review from
elorzafe,
manueliglesias and
yuth
and removed request for
elorzafe
yuth
reviewed
May 3, 2021
...tegory-api/src/provider-utils/awscloudformation/utils/containers/set-existing-secret-arns.ts
Outdated
Show resolved
Hide resolved
yuth
approved these changes
May 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #7224 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 491 491
Lines 25242 25242
Branches 4952 4952
=======================================
Hits 13199 13199
Misses 11091 11091
Partials 952 952 Continue to review full report at Codecov.
|
|
👋 Hi, this pull request was referenced in the v4.51.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0. |
github-actions
bot
added
the
referenced-in-release
cjihrig
pushed a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
When a customer selected "don't update secrets" when deploying changes to a containers resource, the existing secrets config was removed rather than retained. This change adds logic to parse the existing secret config and apply it to the updated template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When a customer selected "don't update secrets" when deploying changes to a containers resource, the existing secrets config was removed rather than retained. This change adds logic to parse the existing secret config and apply it to the updated template
Issue #, if available
#6669
Description of how you validated changes
Manually tested and added unit tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.