Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amplify-provider-awscloudformation): change global_auth_rule to globalAuthRule for global auth #8674

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

danielleadams
Copy link
Member

@danielleadams danielleadams commented Nov 4, 2021

Description of changes

Changes the Global Auth field from global_auth_rule to globalAuthRule. Non breaking as new projects and text specifies globalAuthRule, but the compile still works with global_auth_rule.

Description of how you validated changes

Run unit tests and test binary locally.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danielleadams danielleadams requested a review from a team as a code owner November 4, 2021 21:22
@danielleadams danielleadams marked this pull request as draft November 4, 2021 21:22
@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2021

This pull request introduces 1 alert when merging ed2599c into aad5de7 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@danielleadams danielleadams marked this pull request as ready for review November 5, 2021 00:03
@yuth yuth merged commit 7a06216 into aws-amplify:master Nov 5, 2021
@danielleadams danielleadams deleted the change-sandbox-field branch November 6, 2021 16:13
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Nov 11, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v6.4.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v6.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants