fix: include default values in index arg validation #9759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create and update mutations generate a VTL snippet that verifies that partial sort keys are not provided. However, this snippet only checks for the arguments in $ctx.args.input, which does not include default or computed values. These values are available alongside the user inputs in a variable called $mergedValues. This commit updates the argument checking logic to use the merged values instead of the raw input values. Fixes: #9666
Codecov Report
@@ Coverage Diff @@
## master #9759 +/- ##
=======================================
Coverage 53.01% 53.01%
=======================================
Files 830 830
Lines 46010 46010
Branches 9826 9826
=======================================
Hits 24390 24390
Misses 19602 19602
Partials 2018 2018
Continue to review full report at Codecov.
|
|
👋 Hi, this pull request was referenced in the v7.6.22 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.22. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and update mutations generate a VTL snippet that verifies
that partial sort keys are not provided. However, this snippet
only checks for the arguments in
$ctx.args.input, which doesnot include default or computed values. These values are available
alongside the user inputs in a variable called
$mergedValues.This commit updates the argument checking logic to use the
merged values instead of the raw input values.
Fixes: #9666