fix: use existing rather than deleted models #9769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking for missing function dependencies on API, a model diff against current backend doesn't work if the model was both added, function added with dependency, and model subsequently removed prior to push. This addresses that by looking to see if functions depend on models not in the backend, rather than diffing against cloud backend
|
This pull request introduces 1 alert when merging 88dbf9c into f1af5bb - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #9769 +/- ##
=======================================
Coverage 52.99% 52.99%
=======================================
Files 830 830
Lines 45993 46022 +29
Branches 9823 9837 +14
=======================================
+ Hits 24375 24391 +16
- Misses 19600 19613 +13
Partials 2018 2018
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 247aa25 into 2bd4172 - view on LGTM.com new alerts:
|
4 tasks
jhockett
approved these changes
Feb 17, 2022
...amplify-category-function/src/provider-utils/awscloudformation/utils/getDependentFunction.ts
Outdated
Show resolved
Hide resolved
...amplify-category-function/src/provider-utils/awscloudformation/utils/getDependentFunction.ts
Outdated
Show resolved
Hide resolved
...y-category-function/src/provider-utils/awscloudformation/utils/updateDependentFunctionCfn.ts
Outdated
Show resolved
Hide resolved
jhockett
changed the title
Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
cjihrig
reviewed
Feb 18, 2022
...amplify-category-function/src/provider-utils/awscloudformation/utils/getDependentFunction.ts
Outdated
Show resolved
Hide resolved
...amplify-category-function/src/provider-utils/awscloudformation/utils/getDependentFunction.ts
Outdated
Show resolved
Hide resolved
...amplify-category-function/src/provider-utils/awscloudformation/utils/getDependentFunction.ts
Outdated
Show resolved
Hide resolved
...y-category-function/src/provider-utils/awscloudformation/utils/updateDependentFunctionCfn.ts
Outdated
Show resolved
Hide resolved
cjihrig
approved these changes
Feb 24, 2022
sachscode
added a commit
that referenced
this pull request
Mar 1, 2022
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v7.6.23 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When looking for missing function dependencies on API, a model diff against current backend doesn't work if the model was both added, function added with dependency, and model subsequently removed prior to push. This addresses that by looking to see if functions depend on models not in the backend, rather than diffing against cloud backend
Issue #, if available
#9553
Description of how you validated changes
Running unit tests, making an application and testing using the original reproduction steps
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.