Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amplify_auth_cognito): password management and events #14

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

haverchuck
Copy link
Member

Description of changes:
Adds confirm, reset and change password methods, along with event channel for Hub/Auth events.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

} else {
when (AuthChannelEventName.valueOf(hubEvent.name)) {
AuthChannelEventName.SIGNED_IN -> {
var hubEvent = mapOf("eventName" to "SIGNED_IN")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the mapOf(), is this statement overriding hubEvent to just have the eventName key in it? That is are we only sending the eventName to flutter and no other metadata?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was looking at these events, they seemed to only have some sort of guid in addition to the eventName. So to start out with, I created a key value pair with just the event name under the assumption that we would eventually add additional data.

} on PlatformException catch(e) {
_throwError(e);
}
return res;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to check if we just need a generic catch to avoid having this return?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept getting a complaint from the compiler, but I'm working on this in my next PR.

Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! 🚢 it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants