Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade amplify-android to 1.36.1 #1841

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Jun 30, 2022

Issue #, if available:

Description of changes:

Upgrade amplify-android version to 1.36.1.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@HuiSF HuiSF requested a review from a team as a code owner June 30, 2022 22:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #1841 (e09226d) into main (36a6080) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
+ Coverage   42.11%   42.46%   +0.34%     
==========================================
  Files         372      376       +4     
  Lines       10774    10876     +102     
==========================================
+ Hits         4538     4618      +80     
- Misses       6236     6258      +22     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 31.44% <ø> (ø)
ios-unit-tests 88.92% <ø> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y_flutter_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...e/ios/unit_tests/MockAnalyticsCategoryPlugin.swift 15.38% <0.00%> (ø)
.../ios/unit_tests/amplify_flutter_exampleTests.swift 94.59% <0.00%> (ø)
...ios/example/ios/unit_tests/AtomicResultTests.swift 87.75% <0.00%> (ø)

Copy link
Contributor

@Jordan-Nelson Jordan-Nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Does this need to be cherry-picked to next? We may have already updated in next, but not sure what version we are on now.

@HuiSF
Copy link
Contributor Author

HuiSF commented Jul 1, 2022

Lgtm. Does this need to be cherry-picked to next? We may have already updated in next, but not sure what version we are on now.

I saw a few packages on next uses the dev-preview version of amplify-android.
The blocker fix has also been merged into dev-preview of amplify-android. I think we can update all packages on next to use the dev-preview version of amplify-android.

@HuiSF HuiSF merged commit 0df63cf into aws-amplify:main Jul 6, 2022
@HuiSF HuiSF deleted the chore/amplify-android-1361 branch July 6, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants