chore: Improve testing #1873
Merged
chore: Improve testing #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
chore/ci/test-commands
branch
2 times, most recently
from
c42ac3a
to
34813d9
Compare
dnys1
force-pushed
the
chore/ci/test-commands
branch
from
34813d9
to
91a364f
Compare
Codecov Report
@@ Coverage Diff @@
## next #1873 +/- ##
==========================================
- Coverage 44.04% 43.53% -0.52%
==========================================
Files 122 118 -4
Lines 7529 7427 -102
==========================================
- Hits 3316 3233 -83
+ Misses 4213 4194 -19
Flags with carried forward coverage won't be shown. Click here to find out more. |
dnys1
force-pushed
the
chore/ci/test-commands
branch
3 times, most recently
from
383da6c
to
4b23feb
Compare
dnys1
force-pushed
the
chore/ci/test-commands
branch
2 times, most recently
from
1c14e5c
to
a041eef
Compare
haverchuck
reviewed
Jul 19, 2022
| ```sh | ||
| $ dart test | ||
| $ dart run build_runner test --delete-conflicting-outputs -- -p chrome,firefox | ||
| $ dart run build_runner test --release --delete-conflicting-outputs -- -p chrome,firefox |
There was a problem hiding this comment.
Can this work with Edge, like Flutter tests? If so, might be worth noting somewhere.
There was a problem hiding this comment.
Oh yeah, I forget about edge 😂 I'll see if we can get it running on windows
There was a problem hiding this comment.
Looks like it's not supported yet, unfortunately: dart-lang/test#1142. The Flutter team jumped through some hoops to get it to work (flutter/engine#15641) and I'm not sure if that effort is worth it right now.
haverchuck
approved these changes
Jul 19, 2022
dnys1
force-pushed
the
chore/ci/test-commands
branch
2 times, most recently
from
615ebc2
to
1734bcc
Compare
Jordan-Nelson
approved these changes
Aug 1, 2022
| - linux | ||
| # TODO(dnys1): Secure storage will not work in DDC right now due to ongoing staticInterop changes. | ||
| # Since the interfaces are only ever called via workers (dart2js), this is not a problem but should be monitored. | ||
| # Issue: https://github.com/dart-lang/sdk/issues/49301 |
There was a problem hiding this comment.
This issue is closed. Is this something that has been resolved?
There was a problem hiding this comment.
I'll double check - may only be fixed in dev
added 10 commits
August 2, 2022 09:32
Use `build_test` package to test both DDC and dart2js in CI which will help catch discrepancies earlier in our dev cycle. commit-id:94bb9eb4
Refactors worker_bee tests to allow for DDC/dart2js testing commit-id:87173490
Moves tests to the `_test` package so that they can be run uses `build_runner` which can test DDC/dart2js. commit-id:6130a074
commit-id:aba66832
commit-id:ed4cd5a5
This global helps disambiguate between the multiple combinations of debug, release, and test modes without additional flags needing to be passed to test commands. Potentially, `zDebugMode` could be replaced with this since it's technically more accurate for non-Flutter applications, but since it's non-const we'd lose out on tree-shaking and other compile-time benefits. commit-id:80dc3075
Fixes multiple tests in the new setup by correctly setting build flags and overriding timeouts for browsers where tests with workers run really slow for some reason (not indicative of worker performance). commit-id:30175071
Correctly sets build flags for examples so that `zDebugMode` and `zReleaseMode` function correctly commit-id:605007b2
commit-id:124763b6
commit-id:6a980613
added 5 commits
August 2, 2022 09:36
commit-id:fd730c44
commit-id:c2b9908c
Add `--enable-asserts` for dart2js release code commit-id:c977cea4
commit-id:b6abfc95
It's failing in CI currently and I cannot reproduce locally commit-id:ffcb537d
dnys1
force-pushed
the
chore/ci/test-commands
branch
from
6698c96
to
c1f8101
Compare
commit-id:8b80d358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
build_testpackage to test both DDC and dart2js in CI which will help catch discrepancies earlier in our dev cycle. This requires separating out the tests into a new, private package so that build_runner can correctly discern the dependency graph.