[web] Add Edge support for Flutter Engine unit-tests. #15641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jan 14, 2020
|
thanks for the quick review! |
nturgut
added
the
waiting for tree to go green
|
luci-engine is failing due to Fuchia error. The PR is only related to Flutter web tooling. Merging the PR. |
nturgut
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 15, 2020
flutter/engine@ddaa9dc...bc41ab5 git log ddaa9dc..bc41ab5 --first-parent --oneline 2020-01-15 nurhan@google.com [web] Add Edge support for Flutter Engine unit-tests. (flutter/engine#15641) 2020-01-14 garyq@google.com Add FML_DCHECK to ensure layout before calling getters (flutter/engine#15635) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
* Add Edge support for Flutter Engine unit-tests. This does not include the launcher * Add mapping from browser name to platform. * remove ie from supported browser maps
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* Add Edge support for Flutter Engine unit-tests. This does not include the launcher * Add mapping from browser name to platform. * remove ie from supported browser maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Edge support for Flutter Engine unit-tests. This does not include the launcher.
Note that since Edge is not a supported browser or a supported runtime in dart-sdk, internet explorer is temporarily used for mapping. (Issue added to dart-sdk/test: dart-lang/test#1142)
How to run engine unit tests on windows:
--build-filter option of build_runner didn't work on windows so for now there is not an option for running an individual test.
Fixes: flutter/flutter#48456