fix(sigv4): Make body signing configurable #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
approved these changes
Nov 4, 2022
ragingsquirrel3
approved these changes
Nov 4, 2022
Adds `signBody` as a parameter to `ServiceConfiguration` so that it can be configured on a per-client basis, as suggested by the test suite.
dnys1
force-pushed
the
fix/signer/sign-body
branch
from
2eec3d9
to
f1c1a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
signBodyas a parameter toServiceConfigurationso that it can be configured on a per-client basis, as suggested by the test suite.