Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amplify analytics #4

Merged
merged 1 commit into from Jul 23, 2020
Merged

Amplify analytics #4

merged 1 commit into from Jul 23, 2020

Conversation

fjnoyp
Copy link
Contributor

@fjnoyp fjnoyp commented Jul 15, 2020 •
edited

Description of changes:

This PR includes '''amplify_analytics_plugin_interface"' and '''amplify_analytics_pinpoint''' plugin as well as minor changes needed in code.

The plugin implements all analytics methods present in the equivalent ios and android plugin.
Equivalent DART data structures were created to match ones present for ios and android.

The amplify_analytics_pinpoint folder's example app contains a basic DART app integrating the plugin with several UI buttons for calling each of the analytics methods to verify the API is working. You will need to change amplifyconfiguration.dart to point to your own AWS Pinpoint setup to properly receive those events.

Remaining points to work on:

  • Working with Pinpoint team to verify that data is being sent correctly
  • Skipping fields when identifying/tracking a user causes null string crashes on Android and iOS - currently investigating mechanisms to mitigate that error.
  • ChangeLog / Readme aren't written
  • No UnitTests written (All testing done manually via example app)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

haverchuck
haverchuck requested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@haverchuck haverchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! See inline comments for suggestions/questions.

@haverchuck
Copy link
Contributor

Ship it! Just be sure to squash and merge, and try following conventional commit style in the PR title.

@haverchuck haverchuck self-requested a review July 23, 2020 19:32
@fjnoyp
feat(amplify_analytics): initial commit
b942c72 
* Initial commit for amplify-analytics.

- amplify_analytics_pinpoint : Pinpoint plugin package implementing analytics interface

- amplify_analytics_plugin_interface : Analytics interface

- various updates to amplify_core and amplify_core_plugin_interface to support analytics.
@fjnoyp fjnoyp merged commit d6f53c9 into master Jul 23, 2020
fjnoyp added a commit that referenced this pull request Jul 23, 2020
@fjnoyp
Revert "Merge pull request #4 from aws-amplify/amplify_analytics"
d0eee36 
This reverts commit d6f53c9, reversing
changes made to a02e05a.
Amplifiyer
Amplifiyer reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I know I'm late to the party, but just got an opportunity to take a look. There are some minor comments which we can discuss offline, just wanted to leave them here.

.../main/kotlin/com/amazonaws/amplify/amplify_analytics_pinpoint/AmplifyAnalyticsConstructor.kt Show resolved Hide resolved
...in/kotlin/com/amazonaws/amplify/amplify_analytics_pinpoint/AmplifyAnalyticsPinpointPlugin.kt
channel = MethodChannel(flutterPluginBinding.getFlutterEngine().getDartExecutor(), "com.amazonaws.amplify/analytics_pinpoint")
channel.setMethodCallHandler(this);

Amplify.addPlugin(AWSCognitoAuthPlugin())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this here, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's correct. The one issue is that the auth category hasn't been implemented into master branch yet, so if I remove this code, the example app would break.

I guess we can leave this comment here as a note to remove this line once Auth is properly merged into master and can be included as a dependency here?

...in/kotlin/com/amazonaws/amplify/amplify_analytics_pinpoint/AmplifyAnalyticsPinpointPlugin.kt
break
} else {
context = context.applicationContext
Log.e(TAG, "Failed to resolve Application from Context, AWS Pinpoint not initialized")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. But we haven't failed yet, we are still in while loop, right?
  2. Is there a guarantee that the while loop will break?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. That's correct, thanks for catching that. I've moved the fail case outside of the while loop.
  2. I'm no Android expert, but I believe the idea behind context is that it's the encapsulating state of your current location, so at some point you'll reach the root context and have no where else to go.

...in/kotlin/com/amazonaws/amplify/amplify_analytics_pinpoint/AmplifyAnalyticsPinpointPlugin.kt

@JvmStatic
fun registerWith(registrar: Registrar) {
val channel = MethodChannel(registrar.messenger(), "com.amazonaws.amplify/analytics")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong channel name. Also we need to confirm if we want to support pre-Flutter-1.12 Android projects officially.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I changed the channel name.

Sounds like a nice to have though not too sure on customer impact here. Do you know where I can look to find what steps are needed to support pre-Flutter-1.12 Android projects? I've seen update steps but no explicit information on what we might need to do to officially support this. I think we might need to manually create a pre-Flutter-1.12 project and test to see what might break. Perhaps this is something we should mention in our next team meeting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know where I can look to find what steps are needed to support pre-Flutter-1.12 Android projects?

No, I reckon that we will just check the usage of pre-Flutter-1.12 Android projects and if minimal, call out explicitly that we support Flutter X versions onward.

...in/kotlin/com/amazonaws/amplify/amplify_analytics_pinpoint/AmplifyAnalyticsPinpointPlugin.kt Show resolved Hide resolved
packages/amplify_analytics_pinpoint/lib/amplify_analytics_pinpoint.dart Show resolved Hide resolved
packages/amplify_analytics_plugin_interface/lib/analytics_plugin_interface.dart Show resolved Hide resolved
packages/amplify_analytics_plugin_interface/lib/src/Analytics/AnalyticsUserProfile.dart
Comment on lines +33 to +41
if(plan != null){
allProperties["plan"] = plan;
}



if (location != null) {
allProperties["location"] = location.getAllProperties();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some extra new lines throughout the code. We should clean it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed the extra lines. I think this might be a bigger discussion. I know in Jetbrains Rider there is a way to enforce automatic code styling / spacing. I think we should look into this and perhaps have a discussion as a team to get that setup.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be a life saver and a good early investment.

packages/amplify_core_plugin_interface/lib/amplify_analytics_category.dart Show resolved Hide resolved
packages/amplify_core_plugin_interface/lib/amplify_analytics_category.dart Show resolved Hide resolved
@magicmass magicmass mentioned this pull request Aug 21, 2020
Closed
@fjnoyp fjnoyp mentioned this pull request Sep 2, 2020
Closed
@aymane6 aymane6 mentioned this pull request Nov 20, 2020
Closed
@markpearl markpearl mentioned this pull request Jan 4, 2021
Closed
@nitinkhobragade nitinkhobragade mentioned this pull request Feb 20, 2021
Closed
@Abdelazeem777 Abdelazeem777 mentioned this pull request Dec 22, 2021
Closed
@dorontal dorontal mentioned this pull request Jan 28, 2022
Closed
@jody-schering jody-schering mentioned this pull request Jan 30, 2022
Closed
@abasu0713 abasu0713 mentioned this pull request Feb 25, 2022
Closed
@Migos17 Migos17 mentioned this pull request Jun 9, 2022
Closed
9 tasks
@dorontal dorontal mentioned this pull request Jul 12, 2022
Open
9 tasks
dnys1 added a commit that referenced this pull request Jul 22, 2022
@dnys1
chore(core): Emit errors/stack traces in logger (#1897)
d436a1e 
Before

```
flutter: ERROR | SignUpStateMachine | Emitted error
flutter: ERROR | Authenticator | Error in AuthBloc
```

After

```
flutter: ERROR | SignUpStateMachine | Emitted error: InvalidParameterException [Attributes did not conform to the schema: email: The attribute is required, null, null]
#0      HttpOperation.deserializeOutput
package:smithy/…/http/http_operation.dart:278
<asynchronous suspension>
#1      AWSRetryer.retry
package:smithy_aws/…/retry/aws_retryer.dart:160
<asynchronous suspension>
#2      WrappedCognitoIdentityProviderClient.signUp
package:amplify_auth_cognito_dart/…/sdk/sdk_bridge.dart:516
<asynchronous suspension>
#3      SignUpStateMachine.onInitiate
package:amplify_auth_cognito_dart/…/machines/sign_up_state_machine.dart:42
<asynchronous suspension>
#4      SignUpStateMachineBase.resolve
package:amplify_auth_cognito_dart/…/generated/sign_up_state_machine_base.dart:39
<asynchronous suspension>
#5      StateMachine._listenForEvents
package:amplify_core/…/state_machine/state_machine.dart:171
<asynchronous suspension>
flutter: ERROR | Authenticator | Error in AuthBloc: InvalidParameterException [Attributes did not conform to the schema: email: The attribute is required, null, null]
```
dnys1 added a commit to dnys1/amplify-flutter that referenced this pull request Jul 25, 2022
@dnys1
fix(smithy): Proper enum support (aws-amplify#4)
5495ec2 
* fix: Proper enum fixes

* chore: Update goldens

* Add test

* Remove orElse from enum helpers

* Update goldens
dnys1 added a commit to dnys1/amplify-flutter that referenced this pull request Jul 28, 2022
@dnys1
fix(smithy): Proper enum support (aws-amplify#4)
5b810bc 
* fix: Proper enum fixes

* chore: Update goldens

* Add test

* Remove orElse from enum helpers

* Update goldens
dnys1 added a commit to dnys1/amplify-flutter that referenced this pull request Jul 28, 2022
@dnys1
fix(smithy): Proper enum support (aws-amplify#4)
1b66d37 
* fix: Proper enum fixes

* chore: Update goldens

* Add test

* Remove orElse from enum helpers

* Update goldens
@Jordan-Nelson Jordan-Nelson mentioned this pull request Aug 3, 2022
Merged
@adam-fpc adam-fpc mentioned this pull request Nov 15, 2022
Closed
13 tasks
@mrks89 mrks89 mentioned this pull request Jan 7, 2023
Closed
13 tasks
@nabram nabram mentioned this pull request Jan 20, 2023
Closed
@stevegaunt stevegaunt mentioned this pull request May 24, 2023
Closed
13 tasks
fjnoyp referenced this pull request in fjnoyp/amplify-flutter Aug 29, 2023
Fix Attempt #4
951c192
fjnoyp referenced this pull request in fjnoyp/amplify-flutter Sep 5, 2023
update github token access
b63c2f0 
Update Log Metric

TEMP Ensure PR Trigger

try fix

fix formatting issues

fix error 3

fix ending )

Pass github token

fix syntax error

remove smart quote BS

Ensure Run

temp

update 2

temp

Hopefully this fixes it

Let’s try again

Fix Attempt #4

fix failing step pipe

fix improper job status

fix dart script namings #7

fix freaking typo #8

fix mappings again #9

Print for Debug #10

Remove Quotes? aws-amplify#11

fixi failing trigger

debug - print dart outputs

fix syntax error

try to get output

force github actions to run

fix syntax stop integ tests

trynig to get output
@BeamTrakLLC BeamTrakLLC mentioned this pull request Nov 20, 2023
Closed
14 tasks
@stam0912 stam0912 mentioned this pull request Dec 2, 2023
Closed
14 tasks
@ranielison ranielison mentioned this pull request Dec 26, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amplifiyer Amplifiyer Amplifiyer left review comments

@haverchuck haverchuck haverchuck approved these changes

@Ashish-Nanda Ashish-Nanda Awaiting requested review from Ashish-Nanda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fjnoyp @haverchuck @Amplifiyer