fix(authenticator): required phone number validator #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
changed the title
khatruong2009
previously approved these changes
Nov 10, 2023
Equartey
reviewed
Nov 10, 2023
| /// The "+" prefix is excluded since validation is performed against the number | ||
| /// without the prefix. That is, if the full number is "+1-123-555-7890", the | ||
| /// "+1" is dropped prior to validation. | ||
| final phoneNumberRegex = RegExp(r'^d+$'); |
There was a problem hiding this comment.
What is this meant to match? Should it not be ^[0-9]+$?
There was a problem hiding this comment.
Yes, the \ should not have been removed. Updated.
Equartey
reviewed
Nov 10, 2023
| @@ -118,6 +118,44 @@ void main() { | |||
| }, | |||
| ); | |||
|
|
|||
| testWidgets( | |||
| 'displays message when submitted with empty phone number if the field is required', | |||
There was a problem hiding this comment.
question: Does this test cover the issue that triggered this change? It's unclear how this test was untrue before the changes.
There was a problem hiding this comment.
Yes. Line 149 would fail today on main as the phone number is currently never considered empty as there is always a dial code.
Equartey
approved these changes
Nov 10, 2023
khatruong2009
approved these changes
Nov 10, 2023
Jordan-Nelson
added a commit
to Jordan-Nelson/amplify-flutter
that referenced
this pull request
Nov 13, 2023
Jordan-Nelson
added a commit
that referenced
this pull request
Nov 13, 2023
NikaHsn
pushed a commit
that referenced
this pull request
Dec 5, 2023
* fix(authenticator):required phone number validator * fix: typo in validator
NikaHsn
pushed a commit
that referenced
this pull request
Dec 5, 2023
NikaHsn
pushed a commit
that referenced
this pull request
Dec 5, 2023
- fix(api): GraphQL Model Helpers support lowercase model names #4143 (#4144) - fix(authenticator): required phone number validator ([#4106](#4106)) - fix(core): pub docs ([#4049](#4049)) - fix(datastore): emit observeQuery snapshot when model create mutation results in an updated model ([#4084](#4084)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn
pushed a commit
that referenced
this pull request
Dec 5, 2023
### Fixes - fix(api): GraphQL Model Helpers support lowercase model names #4143 (#4144) - fix(authenticator): required phone number validator ([#4106](#4106)) - fix(core): pub docs ([#4049](#4049)) - fix(datastore): emit observeQuery snapshot when model create mutation results in an updated model ([#4084](#4084)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn
pushed a commit
that referenced
this pull request
Dec 6, 2023
* fix(authenticator):required phone number validator * fix: typo in validator
NikaHsn
pushed a commit
that referenced
this pull request
Dec 6, 2023
NikaHsn
pushed a commit
that referenced
this pull request
Dec 6, 2023
### Fixes - fix(api): GraphQL Model Helpers support lowercase model names #4143 (#4144) - fix(authenticator): required phone number validator ([#4106](#4106)) - fix(core): pub docs ([#4049](#4049)) - fix(datastore): emit observeQuery snapshot when model create mutation results in an updated model ([#4084](#4084)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn
pushed a commit
that referenced
this pull request
Dec 6, 2023
### Fixes - fix(api): GraphQL Model Helpers support lowercase model names #4143 (#4144) - fix(authenticator): required phone number validator ([#4106](#4106)) - fix(core): pub docs ([#4049](#4049)) - fix(datastore): emit observeQuery snapshot when model create mutation results in an updated model ([#4084](#4084)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn
added a commit
that referenced
this pull request
Dec 6, 2023
### Fixes - fix(api): GraphQL Model Helpers support lowercase model names #4143 (#4144) - fix(authenticator): required phone number validator ([#4106](#4106)) - fix(core): pub docs ([#4049](#4049)) - fix(datastore): emit observeQuery snapshot when model create mutation results in an updated model ([#4084](#4084)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4079
Description of changes:
The country code is populated from a drop down list of known valid numbers so there is no need to validate it. Including it in validation makes it challenging to check for a blank phone number since the country code is always present.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.