Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): Bump version #4216

Merged
merged 15 commits into from
Dec 6, 2023
Merged

chore(version): Bump version #4216

merged 15 commits into from
Dec 6, 2023

Conversation

NikaHsn
Copy link
Contributor

@NikaHsn NikaHsn commented Dec 5, 2023

Fixes

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Equartey and others added 15 commits December 5, 2023 11:54
* chore: run integ tests on beta

* chore: pass channel to install dependencies

* chore: update input to use correct param

* chore: update all platforms

* chore: skip tests for beta on PRs

* chore: run auth tests against beta only

* chore: fix env vars

* chore fix env usage

* chore: run auth tests against stable

* chore: test removing IS_AUTH_PACKAGE

* chore: remove env vars for ios tests

* chore: remove changes to non ios platforms

* chore: fix package names

* chore: update remaining platforms

* chore: only run auth tests against beta
… results in an updated model (#4084)

chore: emit snapshot when create results in an update
* fix(authenticator):required phone number validator

* fix: typo in validator
…4106)" (#4117)

Revert "fix(authenticator): required phone number validator (#4106)"

This reverts commit eb6e68b.
* chore(dep): update uuid dependency version range
### Fixes
- fix(api): GraphQL Model Helpers support lowercase model names #4143 (#4144)
- fix(authenticator): required phone number validator ([#4106](#4106))
- fix(core): pub docs ([#4049](#4049))
- fix(datastore): emit observeQuery snapshot when model create mutation results in an updated model ([#4084](#4084))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@NikaHsn NikaHsn requested a review from a team as a code owner December 5, 2023 20:57
@NikaHsn NikaHsn changed the title Chore/release/1.6.2 chore(version): Bump version Dec 5, 2023
Comment on lines -29 to +32
String get aliasedName => _alias ?? 'drift_queued_items';
String get aliasedName => _alias ?? actualTableName;
@override
String get actualTableName => 'drift_queued_items';
String get actualTableName => $name;
static const String $name = 'drift_queued_items';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: are these changes expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, it is a generated file. I think it was missing in #4029 and so was added by aft. #4029 has similar changes for packages/storage/amplify_storage_s3_dart/lib/src/storage_s3_service/transfer/database/database_io.g.dart and for some reason did not update the packages/analytics/amplify_analytics_pinpoint_dart/lib/src/impl/analytics_client/event_client/queued_item_store/drift/drift_queued_item_store.g.dart

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is showing up in the version bump commit (5600e2f) which seems odd.

shouldn't this have been in another commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for some reason it was not updated in the #4029 (drift version update) and so was updated by aft version-bump

@NikaHsn NikaHsn merged commit 01f3231 into stable Dec 6, 2023
426 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants