Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Amplify Android 2.15.0 #4279

Merged
merged 81 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from 80 commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
faf7f7d
chore(deps): Amplify Android 2.14.7
khatruong2009 Dec 21, 2023
67e1e35
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Dec 22, 2023
c759f57
chore: update Kotlin version
khatruong2009 Dec 27, 2023
1c24861
chore: try updating kotlin serialization
khatruong2009 Dec 27, 2023
02f6224
Revert "chore: try updating kotlin serialization"
khatruong2009 Dec 27, 2023
e0eee84
chore: revert kotlin back to last major version
khatruong2009 Dec 27, 2023
3ac2726
chore: revert kotlin to 1.8.22
khatruong2009 Dec 27, 2023
6dab253
chore: upgrade kotlin in the corresponding examples
khatruong2009 Dec 27, 2023
344c15f
chore: update gradle version on datastore example
khatruong2009 Dec 27, 2023
a7edeb6
chore: upgrade gradle
khatruong2009 Dec 28, 2023
0e339a0
chore: attempt to fix gradle url
khatruong2009 Dec 28, 2023
c4fccd8
chore: revert back to last kotlin major version
khatruong2009 Dec 28, 2023
a295039
chore: change gradle version back to 7.4.2
khatruong2009 Dec 29, 2023
9a8cfcc
chore: match Kotlin to Android's version
khatruong2009 Dec 29, 2023
e46a021
chore: make kotlin version consistent through both packages
khatruong2009 Dec 29, 2023
c9b481f
chore: update to new android release
khatruong2009 Dec 29, 2023
1f383f7
chore: downgrade amplify-android version back to 2.14.7 with fix
khatruong2009 Dec 29, 2023
c82259c
chore: bump android version to latest
khatruong2009 Jan 3, 2024
bfbdfe5
chore: bump push notifications to the latest version of android
khatruong2009 Jan 3, 2024
dbe2bb4
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Jan 4, 2024
a8d57bf
chore: try switching to android version 11
khatruong2009 Jan 4, 2024
a36e141
chore: lowered desugaring version
khatruong2009 Jan 4, 2024
7478188
chore: reduced gradle distribution to 7.4
khatruong2009 Jan 4, 2024
e14697a
chore: change kotlin version back to 1.9.10 and gradle distribution u…
khatruong2009 Jan 4, 2024
5223102
chore: move java back to 1_8
khatruong2009 Jan 4, 2024
a9cca7e
chore: changed java version back to 1.8 in example/app/build.gradle
khatruong2009 Jan 4, 2024
eb5a145
chore: put namespace back at the bottom of android
khatruong2009 Jan 4, 2024
766b941
chore: remove change date and put distribution URL back to the bottom
khatruong2009 Jan 4, 2024
05a6101
chore: remove multi-dex
khatruong2009 Jan 5, 2024
f749c70
chore: change the distribution URL back to what it was before
khatruong2009 Jan 8, 2024
761362d
chore: revert changes back to android bump only
khatruong2009 Jan 9, 2024
6fd3088
chore: revert gradle versions on datastore
khatruong2009 Jan 9, 2024
49974f5
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Feb 5, 2024
d1c6bbd
chore: upgrade amplify-android to 2.14.9 and gradle to 8.1.0
khatruong2009 Feb 5, 2024
1cb0f32
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Feb 26, 2024
32ecb67
chore: updated gradle version in datastore example app and added name…
khatruong2009 Feb 26, 2024
74fd3a7
chore: upgrade java version on push notifications and datastore examp…
khatruong2009 Feb 26, 2024
701daac
chore: updated jvm target in datastore and push notifications example…
khatruong2009 Feb 27, 2024
6ef27c8
chore: added proguard rules to datastore and push notifications examp…
khatruong2009 Feb 27, 2024
7f13e59
chore: change java version back to 1.8 for datastore and push notific…
khatruong2009 Feb 27, 2024
901eb10
chore: update java-version in actions.yaml
khatruong2009 Feb 28, 2024
2311139
Revert "chore: update java-version in actions.yaml"
khatruong2009 Feb 28, 2024
b927a27
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Feb 28, 2024
1ee5965
chore: test mvoing android gradle files into new format released by f…
khatruong2009 Feb 29, 2024
72de881
chore: move plugins block to the top
khatruong2009 Feb 29, 2024
3e7203a
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Feb 29, 2024
4a4a56d
Revert "chore: move plugins block to the top"
khatruong2009 Feb 29, 2024
bb70336
Revert "chore: test mvoing android gradle files into new format relea…
khatruong2009 Feb 29, 2024
345d90b
chore: remove proguard files
khatruong2009 Mar 1, 2024
924e06b
chore: added jvm target in datastore to android build.gradle so that …
khatruong2009 Mar 1, 2024
6ece597
chore: try manually adding a java version to the amplify datastore gi…
khatruong2009 Mar 1, 2024
733c5f3
Revert "chore: try manually adding a java version to the amplify data…
khatruong2009 Mar 1, 2024
6217ad2
chore: manually require java 17 in flutter_android.yaml file
khatruong2009 Mar 1, 2024
cf8d252
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Mar 1, 2024
1f2a400
chore: ran ktlintFormat on datastore/android/src/test files
khatruong2009 Mar 1, 2024
bf51528
chore: bump robolectric
khatruong2009 Mar 4, 2024
ba379db
chore: upgrade android to 2.14.11
khatruong2009 Mar 4, 2024
46c3da9
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Mar 7, 2024
09c0f36
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Mar 20, 2024
f7515a9
chore: made changes to uithreadhandler and added injectable datastore…
khatruong2009 Mar 25, 2024
bdaba20
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Mar 25, 2024
0a0a4e8
chore: change Throwable serializer and added uiThreadhandler argument…
khatruong2009 Apr 8, 2024
4da1fbf
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Apr 8, 2024
5ad338a
chore: update to the latest version of android
khatruong2009 Apr 9, 2024
fa6bc51
chore: add GraphQL Exception serializer
khatruong2009 Apr 10, 2024
115f0e8
chore: added comment to trigger tests
khatruong2009 Apr 10, 2024
8b09e93
chore: bump java version to 17 in e2e android test
khatruong2009 Apr 10, 2024
23159e1
Merge branch 'main' into chore/android-2.14.7
khatruong2009 Apr 10, 2024
107ec25
chore: remove test comment used to trigger tests
khatruong2009 Apr 10, 2024
55bd04e
chore: bump amplify-android push notifications version
khatruong2009 Apr 10, 2024
fc31321
chore: remove unnecessary imports and variables
khatruong2009 Apr 11, 2024
7144f4a
chore: removed parcelize and deprecated compileSdkVersion
khatruong2009 Apr 11, 2024
6f69b4f
chore: updated compileSdkVersion to compileSdk
khatruong2009 Apr 12, 2024
f20dc1d
chore: added times called back into test
khatruong2009 Apr 12, 2024
fb01657
chore: upgrade java version to 17 in android packages
khatruong2009 Apr 12, 2024
4eeb993
set java version to 17
Apr 1, 2024
01d87aa
chore: bump compileSdk for secure storage to 34
khatruong2009 Apr 12, 2024
8afd4f5
chore: fix amplify_datastore build.gradle
khatruong2009 Apr 12, 2024
2d7801a
Revert "chore: bump compileSdk for secure storage to 34"
khatruong2009 Apr 12, 2024
0912b4f
chore: change compileSdk to flutter.compileSdkVersion for example app
khatruong2009 Apr 12, 2024
8d613e5
chore: run tests for sdk 24
Jordan-Nelson Apr 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e_android.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- uses: actions/setup-java@cd89f46ac9d01407894225f350157564c9c7cee2 # 3.12.0
with:
distribution: "corretto" # Amazon Corretto Build of OpenJDK
java-version: "11"
java-version: "17"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why to update the java version? I think the java version used in our android packages are still version 8 and so not sure why to use different version on CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newer gradle version to 8.1.0 requires java 17 and above to run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so I think we should update the java version and jvmTraget in the android packages as well


- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/flutter_android.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ jobs:
exclude:
- channel: ${{ (github.event_name == 'pull_request') && 'beta' || 'NONE' }}
steps:
- name: Setup Java
uses: actions/setup-java@cd89f46ac9d01407894225f350157564c9c7cee2 # 3.12.0
with:
distribution: "corretto" # Amazon Corretto Build of OpenJDK
java-version: "17"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above


- name: Git Checkout
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # 3.6.0

Expand Down
6 changes: 3 additions & 3 deletions canaries/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ android {
ndkVersion flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = '1.8'
jvmTarget = '17'
}

sourceSets {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 14 additions & 14 deletions packages/amplify_datastore/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ group 'com.amazonaws.amplify.amplify_datastore'
version '1.0-SNAPSHOT'

buildscript {
ext.kotlin_version = '1.7.10'
ext.kotlin_version = '1.9.10'
repositories {
mavenLocal()
google()
Expand Down Expand Up @@ -32,7 +32,7 @@ apply plugin: 'kotlin-android'
apply plugin: 'org.jlleitschuh.gradle.ktlint'

android {
compileSdkVersion 33
compileSdk 33

sourceSets {
main.java.srcDirs += 'src/main/kotlin'
Expand All @@ -54,11 +54,14 @@ android {
htmlReport false
}
compileOptions {
// Support for Java 8 features
coreLibraryDesugaringEnabled true
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = '17'
}

testOptions {
unitTests {
includeAndroidResources = true
Expand All @@ -69,13 +72,10 @@ android {
}

dependencies {
// Support for Java 8 features
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.0.3'

implementation 'com.amplifyframework:aws-auth-cognito:2.13.0'
implementation "com.amplifyframework:aws-api:2.13.0"
implementation "com.amplifyframework:aws-datastore:2.13.0"
implementation "com.amplifyframework:aws-api-appsync:2.13.0"
implementation 'com.amplifyframework:aws-auth-cognito:2.15.0'
implementation "com.amplifyframework:aws-api:2.15.0"
implementation "com.amplifyframework:aws-datastore:2.15.0"
implementation "com.amplifyframework:aws-api-appsync:2.15.0"
implementation 'com.google.code.gson:gson:2.10.1'
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1'

Expand All @@ -88,7 +88,7 @@ dependencies {

// Tests must be updated if bumped
//noinspection GradleDependency
testImplementation 'org.robolectric:robolectric:4.3.1'
testImplementation 'org.robolectric:robolectric:4.12.1'
testImplementation 'com.fasterxml.jackson.core:jackson-core:2.12.4'
testImplementation 'com.fasterxml.jackson.core:jackson-annotations:2.12.4'
testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.12.4'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-bin.zip
networkTimeout=10000
Equartey marked this conversation as resolved.
Show resolved Hide resolved
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip