chore(deps): Amplify Android 2.15.0 #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c24861.
khatruong2009
changed the title
14 tasks
Equartey
reviewed
Apr 11, 2024
packages/amplify_datastore/android/gradle/wrapper/gradle-wrapper.properties
Show resolved
Hide resolved
...ons/push/amplify_push_notifications/example/android/gradle/wrapper/gradle-wrapper.properties
Show resolved
Hide resolved
NikaHsn
reviewed
Apr 11, 2024
| @@ -45,7 +45,7 @@ jobs: | |||
| - uses: actions/setup-java@cd89f46ac9d01407894225f350157564c9c7cee2 # 3.12.0 | |||
| with: | |||
| distribution: "corretto" # Amazon Corretto Build of OpenJDK | |||
| java-version: "11" | |||
| java-version: "17" | |||
There was a problem hiding this comment.
why to update the java version? I think the java version used in our android packages are still version 8 and so not sure why to use different version on CI.
There was a problem hiding this comment.
The newer gradle version to 8.1.0 requires java 17 and above to run.
There was a problem hiding this comment.
I see, so I think we should update the java version and jvmTraget in the android packages as well
| uses: actions/setup-java@cd89f46ac9d01407894225f350157564c9c7cee2 # 3.12.0 | ||
| with: | ||
| distribution: "corretto" # Amazon Corretto Build of OpenJDK | ||
| java-version: "17" |
...ndroid/src/test/kotlin/com/amazonaws/amplify/amplify_datastore/AmplifyDataStorePluginTest.kt
Outdated
Show resolved
Hide resolved
This reverts commit 01d87aa.
NikaHsn
approved these changes
Apr 15, 2024
Jordan-Nelson
approved these changes
Apr 15, 2024
NikaHsn
pushed a commit
that referenced
this pull request
Apr 16, 2024
* chore(deps): Amplify Android 2.15.0 * chore: update Kotlin version --------- Co-authored-by: Nika Hassani <nikaws@amazon.com> Co-authored-by: Jordan Nelson <Jordanryannelson@gmail.com>
NikaHsn
pushed a commit
that referenced
this pull request
Apr 17, 2024
* chore(deps): Amplify Android 2.15.0 * chore: update Kotlin version --------- Co-authored-by: Nika Hassani <nikaws@amazon.com> Co-authored-by: Jordan Nelson <Jordanryannelson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.