Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update plus plugins version #4619

Merged
merged 10 commits into from Apr 16, 2024
Merged

Conversation

NikaHsn
Copy link
Contributor

@NikaHsn NikaHsn commented Mar 30, 2024

Issue #, if available: #4601

Description of changes:

  • update dart sdk to ^3.3.0 (required for package_info_plus ^6.0.0, device_info_plus: ^10.0.1, connectivity_plus: ^6.0.1)
  • update flutter sdk to ^3.19.0 (required for package_info_plus ^6.0.0, device_info_plus: ^10.0.1, connectivity_plus: ^6.0.1)
  • run dart fix
  • update plus plugins versions
  • set kotlin version to 1.9.10 and gradle version to 8.1.0 across all projects (remaining from chore(deps): Amplify Android 2.15.0 #4279)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn force-pushed the feat/update_plus_plugins_version branch 5 times, most recently from 8b8ebb7 to 57e0824 Compare April 1, 2024 23:36
@NikaHsn NikaHsn force-pushed the feat/update_plus_plugins_version branch 2 times, most recently from a117208 to 84185d2 Compare April 15, 2024 18:57
@NikaHsn NikaHsn force-pushed the feat/update_plus_plugins_version branch from 84185d2 to d6714d0 Compare April 15, 2024 19:12
@NikaHsn NikaHsn marked this pull request as ready for review April 15, 2024 23:03
@NikaHsn NikaHsn requested a review from a team as a code owner April 15, 2024 23:03
@@ -114,10 +114,10 @@ jobs:
- name: Git Checkout
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # 3.5.3

- uses: actions/setup-java@cd89f46ac9d01407894225f350157564c9c7cee2 # 3.12.0
- uses: actions/setup-java@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is there a reason we are changing this from a sha to a version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to use the same commit sha as before

Comment on lines +21 to +22
final isConnected = connectivityResults
.any((result) => result != ConnectivityResult.none);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What should the behavior be if the result contains ConnectivityResult.none AND ConnectivityResult.wifi? Is that possible?


nit: I think you can simplify this:

final isConnected = connectivityResults.contains(ConnectivityResult.none);

This is out of scope for this PR, but it seems like ConnectivityResult.bluetooth would be treated like an active connection. Same with ConnectivityResult.other. I am not sure if we want to treat those like an active connection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on their doc it is not possible to have ConnectivityResult.none AND ConnectivityResult.wifi.

In case of no connectivity, the list contains a single element of [ConnectivityResult.none]. Note also that this is the only case where [ConnectivityResult.none] is present.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean

final isNotConnected = connectivityResults.contains(ConnectivityResult.none);

I think this may be less efficent as it checks all the elements in the list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is what I meant.

.contains() will exit at the first element that matches.

Here is the implementation.

  bool contains(Object? element) {
    for (E e in this) {
      if (e == element) return true;
    }
    return false;
  }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, this is the case where the list contains ConnectivityResult.none (it happens when the device is not conntected and the list supposed to only have one element and it is ConnectivityResult.none). I meant the senarios when the device is connected and so the list may have multiple elements and none of them is ConnectivityResult.none

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Makes sense.

@NikaHsn NikaHsn merged commit 08271d8 into main Apr 16, 2024
440 checks passed
NikaHsn added a commit that referenced this pull request Apr 16, 2024
* update dart and flutter sdk version
* run dart fix
* update _plus plugin versions and fix the code for breaking changes
NikaHsn pushed a commit that referenced this pull request Apr 16, 2024
### Features
- feat: deprecate `Storage.move()` API ([#4638](#4638))
- feat: update `built_value` version constraint ([#4634](#4634))
- feat: update plus plugins version ([#4619](#4619))

### Fixes
- fix(api): Paginated GraphQL preserve request params ([#4605](#4605))
- fix(api): Web socket decode connection errors ([#4606](#4606))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Apr 16, 2024
### Features
- feat: deprecate `Storage.move()` API ([#4638](#4638))
- feat: update `built_value` version constraint ([#4634](#4634))
- feat: update plus plugins version ([#4619](#4619))

### Fixes
- fix(api): Paginated GraphQL preserve request params ([#4605](#4605))
- fix(api): Web socket decode connection errors ([#4606](#4606))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Apr 16, 2024
### Features
- feat: deprecate `Storage.move()` API ([#4638](#4638))
- feat: update `built_value` version constraint ([#4634](#4634))
- feat: update plus plugins version ([#4619](#4619))

### Fixes
- fix(api): Paginated GraphQL preserve request params ([#4605](#4605))
- fix(api): Web socket decode connection errors ([#4606](#4606))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Apr 17, 2024
### Features
- feat: deprecate `Storage.move()` API ([#4638](#4638))
- feat: update `built_value` version constraint ([#4634](#4634))
- feat: update plus plugins version ([#4619](#4619))

### Fixes
- fix(api): Paginated GraphQL preserve request params ([#4605](#4605))
- fix(api): Web socket decode connection errors ([#4606](#4606))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn added a commit that referenced this pull request Apr 17, 2024
* update dart and flutter sdk version
* run dart fix
* update _plus plugin versions and fix the code for breaking changes
NikaHsn pushed a commit that referenced this pull request Apr 17, 2024
### Features
- feat: deprecate `Storage.move()` API ([#4638](#4638))
- feat: update `built_value` version constraint ([#4634](#4634))
- feat: update plus plugins version ([#4619](#4619))

### Fixes
- fix(api): Paginated GraphQL preserve request params ([#4605](#4605))
- fix(api): Web socket decode connection errors ([#4606](#4606))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Apr 17, 2024
### Features
- feat: deprecate `Storage.move()` API ([#4638](#4638))
- feat: update `built_value` version constraint ([#4634](#4634))
- feat: update plus plugins version ([#4619](#4619))

### Fixes
- fix(api): Paginated GraphQL preserve request params ([#4605](#4605))
- fix(api): Web socket decode connection errors ([#4606](#4606))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Apr 18, 2024
### Features
- feat: deprecate `Storage.move()` API ([#4638](#4638))
- feat: update `built_value` version constraint ([#4634](#4634))
- feat: update plus plugins version ([#4619](#4619))

### Fixes
- fix(api): Paginated GraphQL preserve request params ([#4605](#4605))
- fix(api): Web socket decode connection errors ([#4606](#4606))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@qwertylolman
Copy link

qwertylolman commented Apr 19, 2024

Because amplify_auth_cognito >=1.8.0 depends on amplify_analytics_pinpoint >=1.8.0 <1.9.0 which depends on package_info_plus ^6.0.0, amplify_auth_cognito >=1.8.0 requires package_info_plus ^6.0.0.
So, because your_app depends on both amplify_auth_cognito 1.8.0 and package_info_plus 7.0.0, version solving failed.

is it an expected behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants