Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): allow offline configuration #4896

Merged
merged 1 commit into from
May 22, 2024

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented May 15, 2024

Issue #, if available: #4688

Description of changes:

  • updated to catch to handle NetworkException instead of AWSHttpException, since the endpoint client does not throw AWSHttpException; it throws NetworkException instead.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner May 15, 2024 22:24
@NikaHsn NikaHsn force-pushed the fix/notifications/configure-offline branch from d2078f9 to f53046e Compare May 22, 2024 18:48
@NikaHsn NikaHsn merged commit 4dc0df5 into main May 22, 2024
18 checks passed
@NikaHsn NikaHsn deleted the fix/notifications/configure-offline branch August 7, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants