[DataStore] ReferenceError: Property 'err' doesn't exist #12824
Comments
|
It happens during this LOG 2024-01-10 15:40:35.448+02:00 [DATASTORE / ApplicationStack_Synced] DataStore event received:
LOG {
"event": "outboxStatus",
"data": {
"isEmpty": false
}
} |
|
Update: The error I report below, we now believe may be a separate DataStore bug. So read the following accordingly. A bit more information on this as I'm working with @dmitryusikriseapps on this: When I attempt to save a model type ( When I tried to use the app to update a Worker's name twice in fairly quick succession, in my testing I couldn't recreate the error above that way. However when I updated the code to make two back to back For reference, I updated our code to do: let updatedWorker = await DataStore.save(
DataStoreModels.Worker.copyOf(remoteWorker, updated => { ... })
);
// Duplicate the update here to show the error:
updatedWorker = await DataStore.save(
DataStoreModels.Worker.copyOf(remoteWorker, updated => { ... })
);Interestingly if I add a sleep in between the two const sleep = (ms: number): Promise<void> => {
return new Promise(resolve => {
setTimeout(resolve, ms);
});
};
log(`updateCurrentWorker(): Saving to DataStore`);
let updatedWorker = await DataStore.save(
DataStoreModels.Worker.copyOf(remoteWorker, updated => { ... })
);
await sleep(15000);
log(`updateCurrentWorker(): Saving to DataStore`);
updatedWorker = await DataStore.save(
DataStoreModels.Worker.copyOf(remoteWorker, updated => { ... })
);Perhaps importantly I can confirm that the DataStore outbox is evented as empty before the 2nd mutation and we still get the problem, so it doesn't seem related to that at least. I am hopeful this error is quite reproducible on your end, but next step is I'm going to check the AppSync logs in CloudWatch and I'll report back on anything interesting I find there. |
|
Looking more into my error directly above, I think it's a separate issue to the one @dmitryusikriseapps reported, but a bug in its own right that I'd like to see fixed. Regarding the original I'm wondering if this issue is related to the React Native environment, and the Hermes engine in particular, as some initial searching indicates it may be. Here is the where the error is coming from: Not being able to reference We'll try and provide as simple a problem recreate as possible, as we'd really like to see any bug identified fixed, as this is totally blocking our migration to v6. |
|
@chrisbonifacio I've spent quite a bit of time trying to narrow down the problem recreation scenario to help recreate this bug in as simple as manner possible. What I found is I could reliably recreate both the Note: I recreated this in a React Native application, and the former error in particular may only be recreatable there, I'm not sure. I am hopeful the instructions below should allow you or others on the team (perhaps @iartemiev ?) to recreate these too with minimal effort. Both @dmitryusikriseapps and I are happy to help as currently this bug(s) is blocking us from migrating to v6 and we'd really like to do that. Problem Recreation ScenariosThe code below works on a simple
These two scenarios are then repeated but a 5 second sleep is added between the two DataStore mutation operations above. This gives 4 different scenaros so far. Finally, I noticed that adding a Pipeline Resolver for the This leads to 8 total test scenarios that I've tested and documented my findings. Problem Recreation Codeconst sleep = (ms: number): Promise<void> => {
return new Promise(resolve => {
setTimeout(resolve, ms);
});
};
let jobInfo = (await DataStore.query(DataStoreModels.ContractorJobInfo, info => info.jobId.eq('dummy-id')))[0];
if (jobInfo == null) {
console.log(`Creating ContractorJobInfo`);
jobInfo = await DataStore.save(
new DataStoreModels.ContractorJobInfo({
contractorId: currentContractor.id,
cognitoUserId: currentContractor.cognitoUserId,
jobId: 'dummy-id',
})
);
} else {
console.log(`Updating ContractorJobInfo initially`);
jobInfo = await DataStore.save(
DataStoreModels.ContractorJobInfo.copyOf(jobInfo, updated => {
updated.contractorId = `changed-${dayjs().toISOString()}`;
})
);
}
// Some of the test scenarios sleep between DataStore operations, others don't
// This is to see how adding a delay (for outbox syncing) affects things
// await sleep(5000);
console.log(`Updating ContractorJobInfo`);
await DataStore.save(
DataStoreModels.ContractorJobInfo.copyOf(jobInfo, updated => {
updated.contractorId = 'overwritten';
})
);Pipeline ResolversAs I mentioned above we have some additional custom PipelineResolvers for
|
Problem Recreation ResultsBased on the code above and 8 different test scenarios I've described, I can consistently recreate both the Though I'll state immediately that I could only recreate the So we'll start when custom Pipeline Resolvers are active: 1. With Custom Pipeline Resolvers ActiveNote: The custom pipeline resolver must modify the data for it to recreate the results below. 1.1 With no
|
Problem SummaryFrom my problem recreation scenarios and results above, I observed a few things.
That complicated the problem recreation steps, so for my recreation scenarios above I just used one model type, but it may be worth noting as it seems a Custom Pipeline resolver modifying data on the first mutation is ultimately what causes the 2nd mutation to fail with Next StepsI've tried to provide as much information as I can in order for you to recreate these problems simply and reliably. They seem high priority to me given the errors. Certainly we cannot migrate to v6 until they are fixed. If you can't recreate them, both @dmitryusikriseapps and I are happy to assist. You may need to test in a React Native environment to recreate some of these issues. We use Expo, and we had to build a custom Development Client through Expo to test with because v6 of the Amplify libraries aren't natively linked in Expo Go (see this Expo discussion: expo/expo/discussions/25586). I'm hopeful experienced AWS DataStore developers such as @chrisbonifacio and @iartemiev can easily recreate this issue and then look for the root cause. That is where our experience really runs dry, but we're happy to assist as we can. |
|
Hi @danrivett! Thank you for taking the time to deep dive into the issues you're experiencing and sharing your findings. I don't have an update just yet, but wanted to let you know we will be looking into it and what you've shared so far helps a ton! |
cwomack
added
investigating
|
@chrisbonifacio it seems like your team has been very busy with other initiatives (gen 2 etc) so I've avoided asking for updates up until now to give some space and time whilst your team is working on other things, but this is still blocking my team from upgrading to v6, and so is becoming higher in priority for us. Is there anything we can do to assist in troubleshooting or investigating this, as we'd really love to see this investigated and any necessary fixes made. |
|
I'd definitely appreciate an update from AWS of some sort. The radio silence is really disconcerting, as it's a blocker for us to migrate to v6. We're willing to assist in recreation and root cause analysis if needed, but we can't solve the problem entirely on our own, and hope AWS Support will engage to assist in resolving this. |
|
I'm not sure who's leading Amplify DataStore support, but I'm very happy to work directly with them either through this ticket or preferably through an AWS Chime meeting to discuss and work out a plan of attack. |
Before opening, please confirm:
JavaScript Framework
React Native
Amplify APIs
Authentication, DataStore, Storage
Amplify Version
v6
Amplify Categories
auth, storage, api
Backend
None
Environment information
Describe the bug
As soon as some
DataStoremutations are called with a break near 1-2 seconds between them, then an unhandled promise is thrown. Then if the application is reloaded, the warning will still be shown. If the current user is signed out and authenticated one more time, then an uncaught error will be thrown. Everything was working well using the 5th version of the aws-amplify library.Expected behavior
No warnings or errors should be thrown.
Reproduction steps
Code Snippet
// Put your code below this line.Log output
aws-exports.js
No response
Manual configuration
No response
Additional configuration
No response
Mobile Device
iPhone 15 Plus
Mobile Operating System
iOS 17.0
Mobile Browser
No response
Mobile Browser Version
No response
Additional information and screenshots
No response
The text was updated successfully, but these errors were encountered: