fix(datastore): consecutive saves #10717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iartemiev
force-pushed
the
ds-consec-saves
branch
from
bce4f08
to
99e1e43
Compare
|
This pull request introduces 1 alert when merging 99e1e43 into 49bdf81 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Codecov Report
@@ Coverage Diff @@
## main #10717 +/- ##
==========================================
- Coverage 85.65% 85.65% -0.01%
==========================================
Files 196 196
Lines 18261 18241 -20
Branches 3892 3887 -5
==========================================
- Hits 15642 15624 -18
+ Misses 2543 2541 -2
Partials 76 76
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Simplifies the outbox version syncing logic for consecutive saves.
The previous implementation did not take into account selection set differences between mutation requests and responses caused by the client only sending updated fields in the request.
Issue #, if available
#9979
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.