Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom user agent core changes for UI handoff #11602

Merged

Conversation

erinleigh90
Copy link
Member

Description of changes

Makes changes to core required to allow UI team to pass information for metrics through the amplify custom user agent.

Description of how you validated changes

Updated test class and ran all tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@erinleigh90 erinleigh90 marked this pull request as ready for review July 10, 2023 19:27
@erinleigh90 erinleigh90 requested review from a team as code owners July 10, 2023 19:27
@erinleigh90 erinleigh90 requested a review from a team as a code owner July 10, 2023 20:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #11602 (45976d9) into main (817a08c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main   #11602   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files         341      341           
  Lines       21578    21581    +3     
  Branches     4609     4611    +2     
=======================================
+ Hits        18047    18050    +3     
  Misses       3244     3244           
  Partials      287      287           
Impacted Files Coverage Δ
packages/core/src/Platform/types.ts 100.00% <ø> (ø)
packages/core/src/Platform/index.ts 97.14% <100.00%> (+0.26%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jimblanc
jimblanc previously approved these changes Jul 11, 2023
Copy link
Member

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like there is a slight bundle size (5B) issue on Notifications

jimblanc
jimblanc previously approved these changes Jul 14, 2023
stocaaro
stocaaro previously approved these changes Jul 15, 2023
@erinleigh90 erinleigh90 dismissed stale reviews from stocaaro and jimblanc via 45976d9 July 15, 2023 16:56
@erinleigh90 erinleigh90 merged commit 7365c34 into aws-amplify:main Jul 17, 2023
2 checks passed
@erinleigh90 erinleigh90 deleted the feat/custom-user-agent-ui/core-changes branch July 17, 2023 18:51
stocaaro added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants