-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom user agent core changes for UI handoff #11602
feat: custom user agent core changes for UI handoff #11602
Conversation
…sent in from other amplify libraries
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11602 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 341 341
Lines 21578 21581 +3
Branches 4609 4611 +2
=======================================
+ Hits 18047 18050 +3
Misses 3244 3244
Partials 287 287
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looks like there is a slight bundle size (5B) issue on Notifications
Description of changes
Makes changes to core required to allow UI team to pass information for metrics through the amplify custom user agent.
Description of how you validated changes
Updated test class and ran all tests.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.