-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Amplify JS release #11696
Merged
release: Amplify JS release #11696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11673) chore: ping @smtihy/types to 1.1.0 to prevent build failure in TS3.8 This is ok because the AWS SDK and crypto dependencies have been pinned already
* chore: move storage code to InternalStorage.ts * chore: update class and module name to InternalStorage and update imports * feat: add customUserAgentDetails param to public methods * feat: add customUserAgentDetails to getProperties methods, fix cancel overload * feat: make Storage extend internal storage and override public methods * feat: export InternalStorage from internals scope * feat: send user agent details from public copy api to service call * fix: add missing storage action, fix other minor issues * feat: add userAgentValue with received user agent details to AWSS3Provider options * fix: send getproperties instead of copy from getproperties method * test: update tests to handle new form of passing user agent * Revert "test: update tests to handle new form of passing user agent" This reverts commit 4bc7c48. * fix: fix jumbled StorageActions * test: update CustomUserAgent test * test: remove storageAction param and asserts from test * chore: increase bundle size limits * chore: publish feature branch for testing * Feat/custom user agent UI/inappmessaging (#11656) * chore: copy InAppMessaging to InternalInAppMessaging * feat: add customUserAgentDetails param to InternalInAppMessaging * feat: make InAppMessaging extend InternalInAppMessaging * feat: send sync userAgentDetails through to service call * fix: add SyncMessages value to InAppMessagingAction * chore: remove extra parameter from non-service-call functions * fix: fix typo in InAppMessagingAction * feat: send user agent details through identify user to service call * chore: remove unused import * feat: allow InAppMessaging to be configured independently of Notifications * test: update tests for internal changes * build: export InternalInAppMessaging from scoped path * fix: resolve bundle size * chore: bundle size settings * chore: increase bundle size limits * chore: fix typo * fix: update references to type with typo * Feat/custom user agent UI/geo (#11657) * chore: copy Geo code into InternalGeo * feat: add geo actions * feat: add customUserAgentDetails to geo provider * feat: add customUserAgentDetails to public api's and send to service calls * feat: make Geo extend InternalGeo and override public API's * build: export InternalGeo from scoped geo/internals path * chore: increase bundle size limits * chore: increase bundle size limits * feat: add user agent param to action that was missed * chore: update doc-strings with new param * Revert "Merge branch 'feat/custom-user-agent-ui/main' into feat/custom-user-agent-ui/storage" This reverts commit f0e8657, reversing changes made to ec1ed1a. * fix: remove userAgentValue from CommonStorageOptions * feat: add userAgentValue param to StorageProvider and implement * fix: update config type to param type at position * test: update test class based on changes * chore: add new param to jsdocs * chore: update comment from LastParameter (now ConfigParameter) * chore: add comment explaining StorageProviderApiOptionsIndexMap * chore: increase bundle size limits * fix: send userAgentValue through storage put and list * chore: remove outdated TODO comment * chore: increase bundle size limits
* chore: copy InAppMessaging to InternalInAppMessaging * feat: add customUserAgentDetails param to InternalInAppMessaging * feat: make InAppMessaging extend InternalInAppMessaging * feat: send sync userAgentDetails through to service call * fix: add SyncMessages value to InAppMessagingAction * chore: remove extra parameter from non-service-call functions * fix: fix typo in InAppMessagingAction * feat: send user agent details through identify user to service call * chore: remove unused import * feat: allow InAppMessaging to be configured independently of Notifications * test: update tests for internal changes * build: export InternalInAppMessaging from scoped path * fix: resolve bundle size * chore: bundle size settings * chore: increase bundle size limits * chore: fix typo * fix: update references to type with typo * chore: update jsdocs in InternalInAppMessaging * chore: increase bundle size limit * chore: shorten jsdocs comment * fix: first attempt to fix InAppMessaging internals * fix: fix internals package.json paths * test: fix import form internals * chore: increase bundle size limits
kvramyasri7
approved these changes
Jul 31, 2023
jimblanc
approved these changes
Jul 31, 2023
svidgen
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
previous release: #11661
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.