-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Amplify JS release #11661
Merged
Merged
release: Amplify JS release #11661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add parameter to customUserAgentDetails to capture information sent in from other amplify libraries * chore: remove unused imports * feat: if framework supplied, use supplied value over detected framework * feat: add additionalInfo to the user agent object * chore: import AWSUserAgent as a type only * chore: add comments to user agent details type * test: update platform test for ui handoff changes * chore: update bundle-size limits * chore: resolve bundle size check failures * chore: resolve bundle size check failures * Revert "chore: resolve bundle size check failures" This reverts commit ee0ac18. * chore: increase bundle size limit --------- Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
* chore: update size limit that is too tight * chore(prediction): update size limit after custom s3 client
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> Co-authored-by: AllanZhengYP <zheallan@amazon.com>
…11498) * fix(api-rest): refactor ajax method to not relying on side effects the previous Signer.sign() implementation not only returns signed request, but also sets the signed headers to input request. The recent refactor makes it side-effect-less. However this change breaks RestClient.ajax() clock skew correction which relies on the x-amz-date header set by signer to the input request object to indicate the current client side time. this fix resolves #11480
kvramyasri7
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
AllanZhengYP
requested review from
jimblanc,
kvramyasri7,
a team,
israx and
dpilch
July 20, 2023 18:37
israx
approved these changes
Jul 20, 2023
kvramyasri7
approved these changes
Jul 20, 2023
jimblanc
approved these changes
Jul 20, 2023
david-mcafee
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous release: #11622
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.