Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add contextSpec object shape validation for better debugging #12616

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Nov 22, 2023

Description of changes

Add a validation of the contextSpec object to cover the case that TS type check won't take place so it throws more meaningful error for debugging.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested review from a team as code owners November 22, 2023 18:09
@HuiSF HuiSF merged commit a0f9e26 into main Nov 22, 2023
31 checks passed
@HuiSF HuiSF deleted the hui/chore/core/add-context-spec-validation branch November 22, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants