fix(auth): oAuthStore is used before a valid OAuth config is confirmed #12748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvramyasri7
approved these changes
Dec 23, 2023
There was a problem hiding this comment.
This change looks good to me e2e run seems to pass all the tests. But I have not tested this change in sample app.
kvramyasri7
reviewed
Dec 23, 2023
israx
approved these changes
Dec 23, 2023
AllanZhengYP
approved these changes
Dec 26, 2023
AllanZhengYP
added a commit
to AllanZhengYP/amplify-js
that referenced
this pull request
Dec 26, 2023
…confirmed (aws-amplify#12748)" This reverts commit ae64386.
AllanZhengYP
added a commit
that referenced
this pull request
Dec 26, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Moved the origin call of
cognitoUserPoolsTokenProvider.setWaitForInflightOAuth()in theenableOAuthListenerside effect into theattemptCompleteOAuthFlowfunction.The latter ensures the
oAuthStoregets configured before using.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.