-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support centralized tracking #199
Support centralized tracking #199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 53 53
Lines 2517 2517
Branches 510 510
=======================================
Hits 2285 2285
Misses 221 221
Partials 11 11 Continue to review full report at Codecov.
|
@rlmartin these files have moved to the root and the core logic over to the aws-amplify core package. I don't think there will be much conflicts here outside the file locations, if you can update this to get that moved over that'd be great thanks. This update also includes some of your logic for auth persistence (in aws-amplify now). |
@mlabieniec I'll move it over - thanks. |
f245a94
to
b1b867b
Compare
@mlabieniec in case you missed it, I updated this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
This will allow users to pass in a tracking function to the component, which gets triggered only when the component is displayed. It could potentially be used for other purposes beyond tracking component display.