Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support centralized tracking #199

Merged
merged 4 commits into from
Feb 13, 2018

Conversation

rlmartin
Copy link
Contributor

This will allow users to pass in a tracking function to the component, which gets triggered only when the component is displayed. It could potentially be used for other purposes beyond tracking component display.

@codecov-io
Copy link

codecov-io commented Jan 28, 2018

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files          53       53           
  Lines        2517     2517           
  Branches      510      510           
=======================================
  Hits         2285     2285           
  Misses        221      221           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9613df...a95bebf. Read the comment docs.

@mlabieniec
Copy link
Contributor

@rlmartin these files have moved to the root and the core logic over to the aws-amplify core package. I don't think there will be much conflicts here outside the file locations, if you can update this to get that moved over that'd be great thanks. This update also includes some of your logic for auth persistence (in aws-amplify now).

@rlmartin
Copy link
Contributor Author

rlmartin commented Feb 4, 2018

@mlabieniec I'll move it over - thanks.

@rlmartin
Copy link
Contributor Author

@mlabieniec in case you missed it, I updated this PR.

Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@powerful23 powerful23 merged commit e24e097 into aws-amplify:master Feb 13, 2018
@rlmartin rlmartin deleted the support-centralized-tracking branch February 14, 2018 04:52
powerful23 added a commit that referenced this pull request Feb 16, 2018
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants