async storage -> community #4027

jpaas · 2019-09-16T22:13:57Z

Attempt to fix #3422 by changing AsyncStorage dependency to use @react-native-community/async-storage.

I think a major release bump will be needed in order to separate support for >RN0.60 from <RN0.60.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bneigher · 2019-09-17T00:54:47Z

🤤

aws-amplify/amplify-js#4027

ejdigby · 2019-10-06T16:40:53Z

Please merge this!

birken92

approved, correctly replaces the deprecated library.

alisherakb

Approved that this change works as expected with RN >=0.60

Dellybro · 2019-10-28T19:40:29Z

When can we expect this to go through? I have many projects that aren't keeping my users credentials because of this.

chk-profiq

Fix #4272

TomJKlug · 2019-10-30T14:59:55Z

Would love to see this merged as well.

Dellybro · 2019-10-30T23:45:43Z

Can we get an AWS Rep to review this changes asap?

sospedra · 2019-11-01T16:37:37Z

All these millions on Amazon
And we're here without a single PR merged 😆

Any help AWS pals? 🤷‍♂
I'd be nice to have this merged it's very annoying this YellowWarning box poping in all the time
Plus, this is gonna be deprecated soon 🤔

idanlo · 2019-11-01T18:13:38Z

@sospedra it's already deprecated for people with RN version >=0.60 and the async storage functionality doesn't work for us

sospedra · 2019-11-02T22:10:24Z

Good to know.
Then, this PR shall be close, right?

markmckim · 2019-11-05T08:53:34Z

Any chance someone from AWS can look at this? This is preventing me from releasing. We can't release when user session is not being persisted. This PR has been open for 7 weeks.

Dellybro · 2019-11-11T17:18:39Z

Any chance someone from AWS can look at this? This is preventing me from releasing. We can't release when user session is not being persisted. This PR has been open for 7 weeks.

Temporary solution

import AsyncStorage from '@react-native-community/async-storage';
/*
 * Copyright 2017-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License"). You may not use this file except in compliance with
 * the License. A copy of the License is located at
 *
 *     http://aws.amazon.com/apache2.0/
 *
 * or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
 * CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions
 * and limitations under the License.
 */
const MEMORY_KEY_PREFIX = '@StorageService:';
let dataMemory = {};
/** @class */
export class MemoryStorage {
  /**
   * This is used to set a specific item in storage
   * @param {string} key - the key for the item
   * @param {object} value - the value
   * @returns {string} value that was set
   */
  static setItem(key, value) {
    AsyncStorage.setItem(MEMORY_KEY_PREFIX + key, value);
    dataMemory[key] = value;
    return dataMemory[key];
  }
  /**
   * This is used to get a specific key from storage
   * @param {string} key - the key for the item
   * This is used to clear the storage
   * @returns {string} the data item
   */
  static getItem(key) {
    return Object.prototype.hasOwnProperty.call(dataMemory, key)
      ? dataMemory[key]
      : undefined;
  }
  /**
   * This is used to remove an item from storage
   * @param {string} key - the key being set
   * @returns {string} value - value that was deleted
   */
  static removeItem(key) {
    AsyncStorage.removeItem(MEMORY_KEY_PREFIX + key);
    return delete dataMemory[key];
  }
  /**
   * This is used to clear the storage
   * @returns {string} nothing
   */
  static clear() {
    dataMemory = {};
    return dataMemory;
  }
  /**
   * Will sync the MemoryStorage data from AsyncStorage to storageWindow MemoryStorage
   * @returns {void}
   */
  static sync() {
    if (!MemoryStorage.syncPromise) {
      MemoryStorage.syncPromise = new Promise((res, rej) => {
        AsyncStorage.getAllKeys((errKeys, keys) => {
          if (errKeys) rej(errKeys);
          const memoryKeys = keys.filter(key =>
            key.startsWith(MEMORY_KEY_PREFIX),
          );
          AsyncStorage.multiGet(memoryKeys, (err, stores) => {
            if (err) rej(err);
            stores.map((result, index, store) => {
              const key = store[index][0];
              const value = store[index][1];
              const memoryKey = key.replace(MEMORY_KEY_PREFIX, '');
              dataMemory[memoryKey] = value;
            });
            res();
          });
        });
      });
    }
    return MemoryStorage.syncPromise;
  }
}
MemoryStorage.syncPromise = null;
/** @class */
export default class StorageHelper {
  /**
   * This is used to get a storage object
   * @returns {object} the storage
   */
  constructor() {
    this.storageWindow = MemoryStorage;
  }
  /**
   * This is used to return the storage
   * @returns {object} the storage
   */
  getStorage() {
    return this.storageWindow;
  }
}

import { awsConfig } from './src/aws';
import { MemoryStorage } from './src/modules/MemoryStorage'; // workaround because aws-amplify has a huge bug in it.
awsConfig.Auth['storage'] = MemoryStorage;
Amplify.configure(awsConfig);

markmckim · 2019-11-12T19:56:52Z

Is this not being merged because there is a merge conflict? If so, @jpaas can you update your PR?

tfendt · 2019-11-25T04:16:21Z

I think a fix has been merged? 1207227

lucianomlima · 2020-01-24T16:37:52Z

packages/amazon-cognito-identity-js/package.json

@@ -67,6 +67,7 @@
    "js-cookie": "^2.1.4"
  },
  "devDependencies": {
+    "@react-native-community/async-storage": "^1.6.1",


Maybe can update to latest version

@jpaas can you resolve this?

sofyan-ahmad · 2020-04-30T05:04:39Z

In case you need a workaround solution for this ASAP, you can see my code here:

import {Auth} from 'aws-amplify';
import AsyncStorage from '@react-native-community/async-storage';
import {ICognitoStorage} from 'amazon-cognito-identity-js';

const MEMORY_KEY_PREFIX = '@fcAuth:';
let dataMemory = {};
const syncPromise: Promise<any> = null;

/**
 * This is used to set a specific item in storage
 */
function setItem(key: string, value: any) {
  AsyncStorage.setItem(MEMORY_KEY_PREFIX + key, value);
  dataMemory[key] = value;
  return dataMemory[key];
}

/**
 * This is used to get a specific key from storage
 */
function getItem(key: string) {
  return Object.prototype.hasOwnProperty.call(dataMemory, key)
    ? dataMemory[key]
    : undefined;
}

/**
 * This is used to remove an item from storage
 */
function removeItem(key: string) {
  AsyncStorage.removeItem(MEMORY_KEY_PREFIX + key);
  return delete dataMemory[key];
}

/**
 * This is used to clear the storage
 */
function clear() {
  dataMemory = {};
  return dataMemory;
}

/**
 * Will sync the MemoryStorage data from AsyncStorage to storageWindow MemoryStorage
 */
async function sync() {
  if (!syncPromise) {
    try {
      // syncPromise = new Promise((res, rej) => {
      const keys = await AsyncStorage.getAllKeys();

      const memoryKeys = keys.filter((key: string) =>
        key.startsWith(MEMORY_KEY_PREFIX),
      );

      const stores: string[][] = await AsyncStorage.multiGet(memoryKeys);

      stores.map((store: string[]) => {
        const key = store[0];
        const value = store[1];
        const memoryKey = key.replace(MEMORY_KEY_PREFIX, '');

        dataMemory[memoryKey] = value;
      });
    } catch (err) {
      console.error(err);
    }
  }

  return syncPromise;
}

export const AuthStorage: ICognitoStorage & {sync: () => Promise<any>} = {
  setItem,
  getItem,
  removeItem,
  clear,
  sync,
};

Auth.configure({
  storage: AuthStorage,
});

woltsu · 2020-05-07T15:42:13Z

Any updates on this?

Ashish-Nanda · 2020-05-13T15:02:32Z

Hi All,

There is a reason we have not yet migrated to the community version of AsyncStorage yet, and that is because of continued support for Expo managed apps. Also while we get deprecation warnings in React Native, AsyncStorage is still available and works. Thus we felt the best way to support both sets of (React Native CLI and Expo) users was to continue using AsyncStorage from React Native at this time.

I had previously created a PR back in Nov to migrate to the community edition of AsyncStorage #4402

However we didnt end up releasing that as expo users would need to eject their app, since the community edition of AsyncStorage was not available for expo managed apps at the time. This would be a major issue if all our expo users now had to eject their apps.

So we are currently waiting for expo to add this dependency so that we can migrate Amplify JS to use react-native-community/async-storage. Here is the feature request being tracked by Expo: https://expo.canny.io/feature-requests/p/continued-support-for-asyncstorage

We are open to suggestions but I want to make sure you all are aware why we are holding off on this. One thing we could do is to create an npm tag specifically for ReactNativeCLI apps with the change, and then we can merge it into master once Expo supports react-native-community/async-storage. Alternatively you can go with a solution like the one by @sofyan-ahmad above

belal-mazlom · 2020-07-27T16:52:18Z

@Ashish-Nanda
I think expo already support now AsyncStorage community edition!
https://docs.expo.io/versions/latest/sdk/async-storage/

Is there a plan to merge this PR?

Naturalclar · 2020-10-30T10:36:04Z

It would probably better for the reviewer if the conflicts are solved 😃

Cezar-Bytex · 2021-01-14T08:41:30Z

Any updates on this? Should we create a different pull request and get it merged?

nguyenthetoan · 2021-02-03T04:42:47Z

hi, any updates for this in 2021? 🙄

sotomaque · 2021-02-24T00:39:34Z

any updates?

noumansakhawat-dev · 2021-03-04T10:31:43Z

need this to merge asap

lucianomlima · 2021-04-01T20:17:13Z

packages/amazon-cognito-identity-js/package.json

@@ -67,6 +67,7 @@
    "js-cookie": "^2.1.4"
  },
  "devDependencies": {
+    "@react-native-community/async-storage": "^1.6.1",


@jpaas can you resolve this?

lucianomlima · 2021-04-01T20:17:29Z

packages/amazon-cognito-identity-js/package.json

@@ -84,7 +85,7 @@
    "eslint-plugin-standard": "^3.0.1",
    "jsdoc": "^3.4.0",
    "react": "^16.0.0",
-    "react-native": "^0.44.0",
+    "react-native": "^0.60.0",


Maybe update RN version here too

Ashish-Nanda · 2021-05-10T20:53:30Z

Hi All,
The PR #8250 to migrate to the community version of AsyncStorage has just been merged to main. Going to go ahead and close out this PR as a result.
Please refer #6031 (comment) for latest updates on the release.

github-actions · 2022-05-11T02:11:54Z

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

async storage -> community

92dc9b9

jpaas marked this pull request as ready for review September 16, 2019 22:27

jpaas mentioned this pull request Sep 16, 2019

Remove import of deprecated AsyncStorage from 'react-native' and change to '@react-native-community/async-storage' #3991

Closed

jjimenez-industrious pushed a commit to jjimenez-industrious/amplify-js that referenced this pull request Sep 18, 2019

https://github.com/jpaas/amplify-js/tree/rn60

6c96a50

aws-amplify/amplify-js#4027

darko-dev mentioned this pull request Sep 23, 2019

Federated Sign In - NoUserPoolError: Authentication Error #4001

Closed

markmckim mentioned this pull request Oct 22, 2019

login data not saved in AsyncStorage, auth state not persisted #3956

Closed

idanlo mentioned this pull request Oct 27, 2019

AsyncStorage wrong import - removed from react-native and moved to different package #4272

Closed

birken92 approved these changes Oct 28, 2019

View reviewed changes

usmansbk approved these changes Oct 28, 2019

View reviewed changes

alisherakb reviewed Oct 28, 2019

View reviewed changes

chk-profiq approved these changes Oct 30, 2019

View reviewed changes

Dellybro approved these changes Oct 30, 2019

View reviewed changes

Dellybro referenced this pull request Oct 30, 2019

Preparing release

1dbd6e5

lucianomlima approved these changes Jan 24, 2020

View reviewed changes

ADCrouch mentioned this pull request May 19, 2020

currentSession and currentAuthenticatedUser are throwing errors after an app update #5808

Closed

Ashish-Nanda mentioned this pull request May 23, 2020

Swap the native module used when in Expo managed workflow react-native-async-storage/async-storage#368

Merged

amhinson changed the base branch from master to main June 18, 2020 19:04

amhinson mentioned this pull request Jul 16, 2020

Import AsyncStorage from @react-native-community instead of react-native #6341

Closed

serhiiharbo mentioned this pull request Dec 4, 2020

Require Cycle and Async Storage warning #6031

Closed

lucianomlima reviewed Apr 1, 2021

View reviewed changes

agileurbanite added the React Native React Native related issue label Apr 15, 2021

Ashish-Nanda closed this May 10, 2021

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

async storage -> community #4027

async storage -> community #4027

jpaas commented Sep 16, 2019 •

edited

Loading

bneigher commented Sep 17, 2019

ejdigby commented Oct 6, 2019

birken92 left a comment

alisherakb left a comment

Dellybro commented Oct 28, 2019

chk-profiq left a comment

TomJKlug commented Oct 30, 2019

Dellybro commented Oct 30, 2019

sospedra commented Nov 1, 2019

idanlo commented Nov 1, 2019

sospedra commented Nov 2, 2019 •

edited

Loading

markmckim commented Nov 5, 2019

Dellybro commented Nov 11, 2019

markmckim commented Nov 12, 2019

tfendt commented Nov 25, 2019

lucianomlima Jan 24, 2020

lucianomlima Apr 1, 2021

sofyan-ahmad commented Apr 30, 2020

woltsu commented May 7, 2020

Ashish-Nanda commented May 13, 2020

belal-mazlom commented Jul 27, 2020

Naturalclar commented Oct 30, 2020

Cezar-Bytex commented Jan 14, 2021

nguyenthetoan commented Feb 3, 2021 •

edited

Loading

sotomaque commented Feb 24, 2021 •

edited

Loading

noumansakhawat-dev commented Mar 4, 2021

lucianomlima Apr 1, 2021

lucianomlima Apr 1, 2021

Ashish-Nanda commented May 10, 2021 •

edited

Loading

github-actions bot commented May 11, 2022

async storage -> community #4027

async storage -> community #4027

Conversation

jpaas commented Sep 16, 2019 • edited Loading

bneigher commented Sep 17, 2019

ejdigby commented Oct 6, 2019

birken92 left a comment

Choose a reason for hiding this comment

alisherakb left a comment

Choose a reason for hiding this comment

Dellybro commented Oct 28, 2019

chk-profiq left a comment

Choose a reason for hiding this comment

TomJKlug commented Oct 30, 2019

Dellybro commented Oct 30, 2019

sospedra commented Nov 1, 2019

idanlo commented Nov 1, 2019

sospedra commented Nov 2, 2019 • edited Loading

markmckim commented Nov 5, 2019

Dellybro commented Nov 11, 2019

markmckim commented Nov 12, 2019

tfendt commented Nov 25, 2019

lucianomlima Jan 24, 2020

Choose a reason for hiding this comment

lucianomlima Apr 1, 2021

Choose a reason for hiding this comment

sofyan-ahmad commented Apr 30, 2020

woltsu commented May 7, 2020

Ashish-Nanda commented May 13, 2020

belal-mazlom commented Jul 27, 2020

Naturalclar commented Oct 30, 2020

Cezar-Bytex commented Jan 14, 2021

nguyenthetoan commented Feb 3, 2021 • edited Loading

sotomaque commented Feb 24, 2021 • edited Loading

noumansakhawat-dev commented Mar 4, 2021

lucianomlima Apr 1, 2021

Choose a reason for hiding this comment

lucianomlima Apr 1, 2021

Choose a reason for hiding this comment

Ashish-Nanda commented May 10, 2021 • edited Loading

github-actions bot commented May 11, 2022

jpaas commented Sep 16, 2019 •

edited

Loading

sospedra commented Nov 2, 2019 •

edited

Loading

nguyenthetoan commented Feb 3, 2021 •

edited

Loading

sotomaque commented Feb 24, 2021 •

edited

Loading

Ashish-Nanda commented May 10, 2021 •

edited

Loading