Explicitly set responseType to blob rather than using new Blob
#5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amplifiyer
approved these changes
Apr 1, 2020
amhinson
approved these changes
Apr 1, 2020
ericclemmons
added
bug
Codecov Report
@@ Coverage Diff @@
## master #5260 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 195 195
Lines 11464 11464
Branches 2157 2157
=======================================
Hits 8336 8336
Misses 2978 2978
Partials 150 150
Continue to review full report at Codecov.
|
2 tasks
This was referenced May 14, 2021
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish:masterwas blocked by a failing integration test:The regression was intermittent, but ultimately was due to iOS not getting a correct
blobwhen created vianew Blob([response.data]).By using Axios' built-in
responseType: "blob", this bypasses theBlobbug specific to iOS, returningnullforresult:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.