Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerful23 dev #57

Merged
merged 8 commits into from
Dec 11, 2017
Merged

Conversation

powerful23
Copy link
Contributor

Store federated info into Cache for later use.

Clear cache when signed out.

A small fix for Cache.

Commented out some lines of _ensureCredentials() in Storage and Analytics

Change the currentCredentials() function in Auth

@codecov-io
Copy link

Codecov Report

Merging #57 into master will increase coverage by 0.59%.
The diff coverage is 52.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   66.74%   67.34%   +0.59%     
==========================================
  Files          47       49       +2     
  Lines        2210     2226      +16     
  Branches      466      465       -1     
==========================================
+ Hits         1475     1499      +24     
+ Misses        659      651       -8     
  Partials       76       76
Impacted Files Coverage Δ
packages/aws-amplify/src/Cache/StorageCache.ts 79.16% <ø> (ø) ⬆️
packages/aws-amplify/src/Analytics/Analytics.ts 84.61% <ø> (-5.61%) ⬇️
packages/aws-amplify/src/Storage/Storage.ts 98.03% <ø> (+3.86%) ⬆️
...kages/aws-amplify/src/Cache/BrowserStorageCache.ts 93.52% <100%> (ø) ⬆️
packages/aws-amplify/src/Cache/InMemoryCache.ts 94.61% <100%> (ø) ⬆️
packages/aws-amplify/src/Auth/Auth.ts 75.69% <47.05%> (-0.99%) ⬇️
packages/aws-amplify/src/Cache/index.ts 100% <0%> (ø)
packages/aws-amplify/src/Cache/types/index.ts 100% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4e3c6...c87ba7f. Read the comment docs.

@richardzcode richardzcode merged commit 13e890e into aws-amplify:master Dec 11, 2017
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants