New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@aws-amplify/datastore): selective sync enhancements #7083
Conversation
This pull request introduces 1 alert when merging da4b9e4 into cf511b8 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## main #7083 +/- ##
==========================================
- Coverage 72.98% 72.95% -0.04%
==========================================
Files 213 213
Lines 13293 13298 +5
Branches 2603 2510 -93
==========================================
- Hits 9702 9701 -1
- Misses 3395 3432 +37
+ Partials 196 165 -31
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging a17a614 into cf511b8 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ivan, this looks good! 🌮
Good catch by persisting the predicate!
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Predicates.ALL
fromsyncExpression
- allows clearing the syncExpression at runtimelastSyncPredicate
toModelMetadata
in order to better detect when the predicates have changed, e.g., if developer stops application, changes thesyncExpression
and then restart their application.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.