fix(@aws-amplify/datastore): check read-only at instance level #8794

iartemiev · 2021-08-23T20:53:38Z

Description of changes

Check read-only fields at the instance level, instead of at DataStore.save
Resolves bug where error was being thrown during .copyOf call without modifying read-only fields

Issue #, if available

#8649

Description of how you validated changes

unit tests
sample app

Checklist

PR description included
yarn test passes
Tests are changed or added
Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nickarocho

This is so much better in every way. Thanks, Ivan! LGTM 👍

nickarocho · 2021-08-23T22:10:47Z

packages/datastore/src/datastore/datastore.ts

-							? uuid4()
-							: ulid();
+					// instancesIds are set by modelInstanceCreator, it is accessible only internally
+					const isInternal = _id !== null && _id !== undefined;


Thanks for storing this value in a defined variable, makes the following code much more readable upon first glance.

I see you also needed it stored to reference later, but still, readability is a great added benefit :)

* added removePluggable function to PubSub to be able to swap providers as needed. * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.17 - @aws-amplify/ui-components@1.7.1 - @aws-amplify/ui-react@1.2.8 - @aws-amplify/ui-storybook@2.0.8 - @aws-amplify/ui-vue@1.1.2 - @aws-amplify/analytics@5.0.8 - @aws-amplify/api-graphql@2.1.0 - @aws-amplify/api-rest@2.0.8 - @aws-amplify/api@4.0.8 - @aws-amplify/auth@4.2.0 - aws-amplify-angular@6.0.8 - aws-amplify-react@5.0.8 - aws-amplify@4.2.2 - @aws-amplify/cache@4.0.10 - @aws-amplify/core@4.2.2 - @aws-amplify/datastore@3.3.0 - @aws-amplify/interactions@4.0.8 - @aws-amplify/predictions@4.0.8 - @aws-amplify/pubsub@4.1.0 - @aws-amplify/pushnotification@4.2.2 - @aws-amplify/storage@4.3.3 - @aws-amplify/xr@3.0.8 * chore(release): update version.ts [ci skip] * Dispose of ?code on error and success (#8166) Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> * chore(geo): add Geo to main readme (#8702) * fix(@aws-amplify/core): Include refreshToken in UniversalStorage for SSR (#7374) Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> * Fix Storage.put SSE-c bug (#8380) * SSE config fix for get and put Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> * fix: function parameters partiy with signIn (#8713) Co-authored-by: Manoj NB <manojnb@amazon.com> * fix(@aws-amplify/ui-components): Remove local storage check (#8730) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.18 - @aws-amplify/ui-components@1.7.2 - @aws-amplify/ui-react@1.2.9 - @aws-amplify/ui-storybook@2.0.9 - @aws-amplify/ui-vue@1.1.3 - @aws-amplify/analytics@5.0.9 - @aws-amplify/api-graphql@2.1.1 - @aws-amplify/api-rest@2.0.9 - @aws-amplify/api@4.0.9 - @aws-amplify/auth@4.2.1 - aws-amplify-angular@6.0.9 - aws-amplify-react@5.0.9 - aws-amplify@4.2.3 - @aws-amplify/cache@4.0.11 - @aws-amplify/core@4.2.3 - @aws-amplify/datastore@3.3.1 - @aws-amplify/interactions@4.0.9 - @aws-amplify/predictions@4.0.9 - @aws-amplify/pubsub@4.1.1 - @aws-amplify/pushnotification@4.2.3 - @aws-amplify/storage@4.3.4 - @aws-amplify/xr@3.0.9 * chore(release): update version.ts [ci skip] * feat(@aws-amplify/auth): Add a 'SUCCESS' response on successful call to forgotPasswordSubmit and verifyUserAttributes(#8744) * added a success message on successful call to forgotPasswordSubmit function * modified test to expect onSuccess to be called with 'SUCCESS' on successful confirmPassword() * added 'SUCCESS' response on successful call to verifyUserAttribute * chore: preparing release * chore(release): Publish [ci skip] - amazon-cognito-identity-js@5.1.0 - @aws-amplify/ui-angular@1.0.19 - @aws-amplify/ui-components@1.7.3 - @aws-amplify/ui-react@1.2.10 - @aws-amplify/ui-storybook@2.0.10 - @aws-amplify/ui-vue@1.1.4 - @aws-amplify/analytics@5.0.10 - @aws-amplify/api-graphql@2.1.2 - @aws-amplify/api-rest@2.0.10 - @aws-amplify/api@4.0.10 - @aws-amplify/auth@4.3.0 - aws-amplify-angular@6.0.10 - aws-amplify-react@5.0.10 - aws-amplify@4.2.4 - @aws-amplify/cache@4.0.12 - @aws-amplify/core@4.2.4 - @aws-amplify/datastore@3.3.2 - @aws-amplify/interactions@4.0.10 - @aws-amplify/predictions@4.0.10 - @aws-amplify/pubsub@4.1.2 - @aws-amplify/pushnotification@4.2.4 - @aws-amplify/storage@4.3.5 - @aws-amplify/xr@3.0.10 * chore(release): update version.ts [ci skip] * GH-4468: Transfer Acceleration can now be passed as a parameter to Storage.put() (#8750) Co-authored-by: James Au <40404256+jamesaucode@users.noreply.github.com> * refactor: change LogLevel of getCurrentUserInfo error (#8434) Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> * Updates to the README (#8782) * chore:Update NOTICE file to remove copyright date * chore:Update README * chore:Update based on feedback from pull request * chore:Fix typos, remove redundancy * chore:Fix typo within the documentation site * chore(issue templates): update template picker for ui repo (#8556) Co-authored-by: Eric Clemmons <eric@smarterspam.com> * fix(@aws-amplify/datastore): check read-only at instance level (#8794) * feat(@aws-amplify/api-graphql): Add support for string 'authmode' values in TypeScript based apps (#8799) * added string authmode values as allowed types * refactoring and using existing types to allow string values for authMode Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.20 - @aws-amplify/ui-components@1.7.4 - @aws-amplify/ui-react@1.2.11 - @aws-amplify/ui-storybook@2.0.11 - @aws-amplify/ui-vue@1.1.5 - @aws-amplify/analytics@5.0.11 - @aws-amplify/api-graphql@2.2.0 - @aws-amplify/api-rest@2.0.11 - @aws-amplify/api@4.0.11 - @aws-amplify/auth@4.3.1 - aws-amplify-angular@6.0.11 - aws-amplify-react@5.0.11 - aws-amplify@4.2.5 - @aws-amplify/cache@4.0.13 - @aws-amplify/core@4.2.5 - @aws-amplify/datastore@3.3.3 - @aws-amplify/interactions@4.0.11 - @aws-amplify/predictions@4.0.11 - @aws-amplify/pubsub@4.1.3 - @aws-amplify/pushnotification@4.2.5 - @aws-amplify/storage@4.3.6 - @aws-amplify/xr@3.0.11 * chore(release): update version.ts [ci skip] * chore(gh action): reduce cron sched to once per day (#8721) Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> * fix(@aws-amplify/datastore): remove conditional require (#8828) * feat(@aws-amplify/datastore): add SQLite storage adapter option for RN apps (#8809) * fix(@aws-amplify/datastore): patch immer vuln (#8841) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.21 - @aws-amplify/ui-components@1.7.5 - @aws-amplify/ui-react@1.2.12 - @aws-amplify/ui-storybook@2.0.12 - @aws-amplify/ui-vue@1.1.6 - @aws-amplify/analytics@5.0.12 - @aws-amplify/api-graphql@2.2.1 - @aws-amplify/api-rest@2.0.12 - @aws-amplify/api@4.0.12 - @aws-amplify/auth@4.3.2 - aws-amplify-angular@6.0.12 - aws-amplify-react@5.0.12 - aws-amplify@4.2.6 - @aws-amplify/cache@4.0.14 - @aws-amplify/core@4.2.6 - @aws-amplify/datastore-storage-adapter@1.1.0 - @aws-amplify/datastore@3.4.0 - @aws-amplify/interactions@4.0.12 - @aws-amplify/predictions@4.0.12 - @aws-amplify/pubsub@4.1.4 - @aws-amplify/pushnotification@4.2.6 - @aws-amplify/storage@4.3.7 - @aws-amplify/xr@3.0.12 * chore(release): update version.ts [ci skip] * fix(@aws-amplify/datastore): only stringify nested AWSJSON in mutation event (#8844) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.22 - @aws-amplify/ui-components@1.7.6 - @aws-amplify/ui-react@1.2.13 - @aws-amplify/ui-storybook@2.0.13 - @aws-amplify/ui-vue@1.1.7 - @aws-amplify/analytics@5.0.13 - @aws-amplify/api-graphql@2.2.2 - @aws-amplify/api-rest@2.0.13 - @aws-amplify/api@4.0.13 - @aws-amplify/auth@4.3.3 - aws-amplify-angular@6.0.13 - aws-amplify-react@5.0.13 - aws-amplify@4.2.7 - @aws-amplify/cache@4.0.15 - @aws-amplify/core@4.2.7 - @aws-amplify/datastore-storage-adapter@1.1.1 - @aws-amplify/datastore@3.4.1 - @aws-amplify/interactions@4.0.13 - @aws-amplify/predictions@4.0.13 - @aws-amplify/pubsub@4.1.5 - @aws-amplify/pushnotification@4.2.7 - @aws-amplify/storage@4.3.8 - @aws-amplify/xr@3.0.13 * chore(release): update version.ts [ci skip] * Modified removePluggable to remove pluggable based on providerName. Updated tests to test if removing then adding a pluggable will replace original. * chore(fix axios version): patch security vuln for api-rest and storage (#8858) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.23 - @aws-amplify/ui-components@1.7.7 - @aws-amplify/ui-react@1.2.14 - @aws-amplify/ui-storybook@2.0.14 - @aws-amplify/ui-vue@1.1.8 - @aws-amplify/analytics@5.0.14 - @aws-amplify/api-graphql@2.2.3 - @aws-amplify/api-rest@2.0.14 - @aws-amplify/api@4.0.14 - @aws-amplify/auth@4.3.4 - aws-amplify-angular@6.0.14 - aws-amplify-react@5.0.14 - aws-amplify@4.2.8 - @aws-amplify/cache@4.0.16 - @aws-amplify/core@4.2.8 - @aws-amplify/datastore-storage-adapter@1.1.2 - @aws-amplify/datastore@3.4.2 - @aws-amplify/interactions@4.0.14 - @aws-amplify/predictions@4.0.14 - @aws-amplify/pubsub@4.1.6 - @aws-amplify/pushnotification@4.2.8 - @aws-amplify/storage@4.3.9 - @aws-amplify/xr@3.0.14 * chore(release): update version.ts [ci skip] * chore(@aws-amplify/pubsub): Add JSDoc to removePluggable function; Update removePluggable unit test so that it fails if plugin is not removed; Format recent changes using Prettier * chore(@aws-amplify/pubsub): minor update to removePluggable unit test * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.24 - @aws-amplify/ui-components@1.7.8 - @aws-amplify/ui-react@1.2.15 - @aws-amplify/ui-storybook@2.0.15 - @aws-amplify/ui-vue@1.1.9 - @aws-amplify/analytics@5.0.15 - @aws-amplify/api-graphql@2.2.4 - @aws-amplify/api-rest@2.0.15 - @aws-amplify/api@4.0.15 - @aws-amplify/auth@4.3.5 - aws-amplify-angular@6.0.15 - aws-amplify-react@5.0.15 - aws-amplify@4.2.9 - @aws-amplify/cache@4.0.17 - @aws-amplify/core@4.2.9 - @aws-amplify/datastore-storage-adapter@1.1.3 - @aws-amplify/datastore@3.4.3 - @aws-amplify/interactions@4.0.15 - @aws-amplify/predictions@4.0.15 - @aws-amplify/pubsub@4.1.7 - @aws-amplify/pushnotification@4.2.9 - @aws-amplify/storage@4.3.10 - @aws-amplify/xr@3.0.15 * chore(release): update version.ts [ci skip] * chore(geo): bring core version up to date Co-authored-by: ZacharyRogers <ztrogers1@gmail.com> Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Eric Clemmons <eric@smarterspam.com> Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: James Au <40404256+jamesaucode@users.noreply.github.com> Co-authored-by: ManojNB <manojnb95@gmail.com> Co-authored-by: Manoj NB <manojnb@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> Co-authored-by: Nick Arocho <nicaroch@amazon.com> Co-authored-by: Khairo Khatib <59224303+Khairo-kh@users.noreply.github.com> Co-authored-by: evcodes <eddvar@amazon.com> Co-authored-by: Carlos Espin <65199391+cespin@users.noreply.github.com> Co-authored-by: h-kishi <h-kishi@users.noreply.github.com> Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> Co-authored-by: siegerts <stephen.siegert@gmail.com> Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> Co-authored-by: James Au <auchu@amazon.com> Co-authored-by: hkjpotato <hkjpotato@gmail.com> Co-authored-by: David McAfee <mcafd@amazon.com>

* feat(geo): add region to Amazon Location Service MapStyle (#8736) * chore(geo): Update name for amazon location service provider (#8872) * chore: merge `main` into `geo/staging` (#8875) * added removePluggable function to PubSub to be able to swap providers as needed. * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.17 - @aws-amplify/ui-components@1.7.1 - @aws-amplify/ui-react@1.2.8 - @aws-amplify/ui-storybook@2.0.8 - @aws-amplify/ui-vue@1.1.2 - @aws-amplify/analytics@5.0.8 - @aws-amplify/api-graphql@2.1.0 - @aws-amplify/api-rest@2.0.8 - @aws-amplify/api@4.0.8 - @aws-amplify/auth@4.2.0 - aws-amplify-angular@6.0.8 - aws-amplify-react@5.0.8 - aws-amplify@4.2.2 - @aws-amplify/cache@4.0.10 - @aws-amplify/core@4.2.2 - @aws-amplify/datastore@3.3.0 - @aws-amplify/interactions@4.0.8 - @aws-amplify/predictions@4.0.8 - @aws-amplify/pubsub@4.1.0 - @aws-amplify/pushnotification@4.2.2 - @aws-amplify/storage@4.3.3 - @aws-amplify/xr@3.0.8 * chore(release): update version.ts [ci skip] * Dispose of ?code on error and success (#8166) Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> * chore(geo): add Geo to main readme (#8702) * fix(@aws-amplify/core): Include refreshToken in UniversalStorage for SSR (#7374) Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> * Fix Storage.put SSE-c bug (#8380) * SSE config fix for get and put Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> * fix: function parameters partiy with signIn (#8713) Co-authored-by: Manoj NB <manojnb@amazon.com> * fix(@aws-amplify/ui-components): Remove local storage check (#8730) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.18 - @aws-amplify/ui-components@1.7.2 - @aws-amplify/ui-react@1.2.9 - @aws-amplify/ui-storybook@2.0.9 - @aws-amplify/ui-vue@1.1.3 - @aws-amplify/analytics@5.0.9 - @aws-amplify/api-graphql@2.1.1 - @aws-amplify/api-rest@2.0.9 - @aws-amplify/api@4.0.9 - @aws-amplify/auth@4.2.1 - aws-amplify-angular@6.0.9 - aws-amplify-react@5.0.9 - aws-amplify@4.2.3 - @aws-amplify/cache@4.0.11 - @aws-amplify/core@4.2.3 - @aws-amplify/datastore@3.3.1 - @aws-amplify/interactions@4.0.9 - @aws-amplify/predictions@4.0.9 - @aws-amplify/pubsub@4.1.1 - @aws-amplify/pushnotification@4.2.3 - @aws-amplify/storage@4.3.4 - @aws-amplify/xr@3.0.9 * chore(release): update version.ts [ci skip] * feat(@aws-amplify/auth): Add a 'SUCCESS' response on successful call to forgotPasswordSubmit and verifyUserAttributes(#8744) * added a success message on successful call to forgotPasswordSubmit function * modified test to expect onSuccess to be called with 'SUCCESS' on successful confirmPassword() * added 'SUCCESS' response on successful call to verifyUserAttribute * chore: preparing release * chore(release): Publish [ci skip] - amazon-cognito-identity-js@5.1.0 - @aws-amplify/ui-angular@1.0.19 - @aws-amplify/ui-components@1.7.3 - @aws-amplify/ui-react@1.2.10 - @aws-amplify/ui-storybook@2.0.10 - @aws-amplify/ui-vue@1.1.4 - @aws-amplify/analytics@5.0.10 - @aws-amplify/api-graphql@2.1.2 - @aws-amplify/api-rest@2.0.10 - @aws-amplify/api@4.0.10 - @aws-amplify/auth@4.3.0 - aws-amplify-angular@6.0.10 - aws-amplify-react@5.0.10 - aws-amplify@4.2.4 - @aws-amplify/cache@4.0.12 - @aws-amplify/core@4.2.4 - @aws-amplify/datastore@3.3.2 - @aws-amplify/interactions@4.0.10 - @aws-amplify/predictions@4.0.10 - @aws-amplify/pubsub@4.1.2 - @aws-amplify/pushnotification@4.2.4 - @aws-amplify/storage@4.3.5 - @aws-amplify/xr@3.0.10 * chore(release): update version.ts [ci skip] * GH-4468: Transfer Acceleration can now be passed as a parameter to Storage.put() (#8750) Co-authored-by: James Au <40404256+jamesaucode@users.noreply.github.com> * refactor: change LogLevel of getCurrentUserInfo error (#8434) Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> * Updates to the README (#8782) * chore:Update NOTICE file to remove copyright date * chore:Update README * chore:Update based on feedback from pull request * chore:Fix typos, remove redundancy * chore:Fix typo within the documentation site * chore(issue templates): update template picker for ui repo (#8556) Co-authored-by: Eric Clemmons <eric@smarterspam.com> * fix(@aws-amplify/datastore): check read-only at instance level (#8794) * feat(@aws-amplify/api-graphql): Add support for string 'authmode' values in TypeScript based apps (#8799) * added string authmode values as allowed types * refactoring and using existing types to allow string values for authMode Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.20 - @aws-amplify/ui-components@1.7.4 - @aws-amplify/ui-react@1.2.11 - @aws-amplify/ui-storybook@2.0.11 - @aws-amplify/ui-vue@1.1.5 - @aws-amplify/analytics@5.0.11 - @aws-amplify/api-graphql@2.2.0 - @aws-amplify/api-rest@2.0.11 - @aws-amplify/api@4.0.11 - @aws-amplify/auth@4.3.1 - aws-amplify-angular@6.0.11 - aws-amplify-react@5.0.11 - aws-amplify@4.2.5 - @aws-amplify/cache@4.0.13 - @aws-amplify/core@4.2.5 - @aws-amplify/datastore@3.3.3 - @aws-amplify/interactions@4.0.11 - @aws-amplify/predictions@4.0.11 - @aws-amplify/pubsub@4.1.3 - @aws-amplify/pushnotification@4.2.5 - @aws-amplify/storage@4.3.6 - @aws-amplify/xr@3.0.11 * chore(release): update version.ts [ci skip] * chore(gh action): reduce cron sched to once per day (#8721) Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> * fix(@aws-amplify/datastore): remove conditional require (#8828) * feat(@aws-amplify/datastore): add SQLite storage adapter option for RN apps (#8809) * fix(@aws-amplify/datastore): patch immer vuln (#8841) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.21 - @aws-amplify/ui-components@1.7.5 - @aws-amplify/ui-react@1.2.12 - @aws-amplify/ui-storybook@2.0.12 - @aws-amplify/ui-vue@1.1.6 - @aws-amplify/analytics@5.0.12 - @aws-amplify/api-graphql@2.2.1 - @aws-amplify/api-rest@2.0.12 - @aws-amplify/api@4.0.12 - @aws-amplify/auth@4.3.2 - aws-amplify-angular@6.0.12 - aws-amplify-react@5.0.12 - aws-amplify@4.2.6 - @aws-amplify/cache@4.0.14 - @aws-amplify/core@4.2.6 - @aws-amplify/datastore-storage-adapter@1.1.0 - @aws-amplify/datastore@3.4.0 - @aws-amplify/interactions@4.0.12 - @aws-amplify/predictions@4.0.12 - @aws-amplify/pubsub@4.1.4 - @aws-amplify/pushnotification@4.2.6 - @aws-amplify/storage@4.3.7 - @aws-amplify/xr@3.0.12 * chore(release): update version.ts [ci skip] * fix(@aws-amplify/datastore): only stringify nested AWSJSON in mutation event (#8844) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.22 - @aws-amplify/ui-components@1.7.6 - @aws-amplify/ui-react@1.2.13 - @aws-amplify/ui-storybook@2.0.13 - @aws-amplify/ui-vue@1.1.7 - @aws-amplify/analytics@5.0.13 - @aws-amplify/api-graphql@2.2.2 - @aws-amplify/api-rest@2.0.13 - @aws-amplify/api@4.0.13 - @aws-amplify/auth@4.3.3 - aws-amplify-angular@6.0.13 - aws-amplify-react@5.0.13 - aws-amplify@4.2.7 - @aws-amplify/cache@4.0.15 - @aws-amplify/core@4.2.7 - @aws-amplify/datastore-storage-adapter@1.1.1 - @aws-amplify/datastore@3.4.1 - @aws-amplify/interactions@4.0.13 - @aws-amplify/predictions@4.0.13 - @aws-amplify/pubsub@4.1.5 - @aws-amplify/pushnotification@4.2.7 - @aws-amplify/storage@4.3.8 - @aws-amplify/xr@3.0.13 * chore(release): update version.ts [ci skip] * Modified removePluggable to remove pluggable based on providerName. Updated tests to test if removing then adding a pluggable will replace original. * chore(fix axios version): patch security vuln for api-rest and storage (#8858) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.23 - @aws-amplify/ui-components@1.7.7 - @aws-amplify/ui-react@1.2.14 - @aws-amplify/ui-storybook@2.0.14 - @aws-amplify/ui-vue@1.1.8 - @aws-amplify/analytics@5.0.14 - @aws-amplify/api-graphql@2.2.3 - @aws-amplify/api-rest@2.0.14 - @aws-amplify/api@4.0.14 - @aws-amplify/auth@4.3.4 - aws-amplify-angular@6.0.14 - aws-amplify-react@5.0.14 - aws-amplify@4.2.8 - @aws-amplify/cache@4.0.16 - @aws-amplify/core@4.2.8 - @aws-amplify/datastore-storage-adapter@1.1.2 - @aws-amplify/datastore@3.4.2 - @aws-amplify/interactions@4.0.14 - @aws-amplify/predictions@4.0.14 - @aws-amplify/pubsub@4.1.6 - @aws-amplify/pushnotification@4.2.8 - @aws-amplify/storage@4.3.9 - @aws-amplify/xr@3.0.14 * chore(release): update version.ts [ci skip] * chore(@aws-amplify/pubsub): Add JSDoc to removePluggable function; Update removePluggable unit test so that it fails if plugin is not removed; Format recent changes using Prettier * chore(@aws-amplify/pubsub): minor update to removePluggable unit test * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.24 - @aws-amplify/ui-components@1.7.8 - @aws-amplify/ui-react@1.2.15 - @aws-amplify/ui-storybook@2.0.15 - @aws-amplify/ui-vue@1.1.9 - @aws-amplify/analytics@5.0.15 - @aws-amplify/api-graphql@2.2.4 - @aws-amplify/api-rest@2.0.15 - @aws-amplify/api@4.0.15 - @aws-amplify/auth@4.3.5 - aws-amplify-angular@6.0.15 - aws-amplify-react@5.0.15 - aws-amplify@4.2.9 - @aws-amplify/cache@4.0.17 - @aws-amplify/core@4.2.9 - @aws-amplify/datastore-storage-adapter@1.1.3 - @aws-amplify/datastore@3.4.3 - @aws-amplify/interactions@4.0.15 - @aws-amplify/predictions@4.0.15 - @aws-amplify/pubsub@4.1.7 - @aws-amplify/pushnotification@4.2.9 - @aws-amplify/storage@4.3.10 - @aws-amplify/xr@3.0.15 * chore(release): update version.ts [ci skip] * chore(geo): bring core version up to date Co-authored-by: ZacharyRogers <ztrogers1@gmail.com> Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Eric Clemmons <eric@smarterspam.com> Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: James Au <40404256+jamesaucode@users.noreply.github.com> Co-authored-by: ManojNB <manojnb95@gmail.com> Co-authored-by: Manoj NB <manojnb@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> Co-authored-by: Nick Arocho <nicaroch@amazon.com> Co-authored-by: Khairo Khatib <59224303+Khairo-kh@users.noreply.github.com> Co-authored-by: evcodes <eddvar@amazon.com> Co-authored-by: Carlos Espin <65199391+cespin@users.noreply.github.com> Co-authored-by: h-kishi <h-kishi@users.noreply.github.com> Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> Co-authored-by: siegerts <stephen.siegert@gmail.com> Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> Co-authored-by: James Au <auchu@amazon.com> Co-authored-by: hkjpotato <hkjpotato@gmail.com> Co-authored-by: David McAfee <mcafd@amazon.com> * fix(@aws-amplify/geo): Update webpack config to mark core as external (#8748) Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com> Co-authored-by: ZacharyRogers <ztrogers1@gmail.com> Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Eric Clemmons <eric@smarterspam.com> Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: James Au <40404256+jamesaucode@users.noreply.github.com> Co-authored-by: ManojNB <manojnb95@gmail.com> Co-authored-by: Manoj NB <manojnb@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> Co-authored-by: Nick Arocho <nicaroch@amazon.com> Co-authored-by: Khairo Khatib <59224303+Khairo-kh@users.noreply.github.com> Co-authored-by: evcodes <eddvar@amazon.com> Co-authored-by: Carlos Espin <65199391+cespin@users.noreply.github.com> Co-authored-by: h-kishi <h-kishi@users.noreply.github.com> Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> Co-authored-by: siegerts <stephen.siegert@gmail.com> Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> Co-authored-by: James Au <auchu@amazon.com> Co-authored-by: hkjpotato <hkjpotato@gmail.com> Co-authored-by: David McAfee <mcafd@amazon.com>

…mplify#8794)

github-actions · 2022-08-25T02:14:49Z

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

iartemiev requested review from manueliglesias, svidgen, nickarocho and ArkamJ August 23, 2021 20:53

fix(@aws-amplify/datastore): check read-only at instance level

c4cbea3

iartemiev force-pushed the ds-issue-8649 branch from 5399132 to c4cbea3 Compare August 23, 2021 21:09

aws-amplify deleted a comment from lgtm-com bot Aug 23, 2021

nickarocho approved these changes Aug 23, 2021

View reviewed changes

iartemiev added 2 commits August 24, 2021 08:20

Merge branch 'main' into ds-issue-8649

0176bfd

Merge branch 'main' into ds-issue-8649

8041e59

ArkamJ approved these changes Aug 24, 2021

View reviewed changes

iartemiev merged commit b278875 into aws-amplify:main Aug 24, 2021

iartemiev deleted the ds-issue-8649 branch August 24, 2021 16:19

snyk-bot mentioned this pull request Sep 4, 2021

[Snyk] Security upgrade @aws-amplify/datastore from 1.2.0 to 3.4.0 0xpixel/amplify-js#45

Open

lmgtfy2 pushed a commit to lmgtfy2/amplify-js that referenced this pull request Sep 28, 2021

fix(@aws-amplify/datastore): check read-only at instance level (aws-a…

1939829

…mplify#8794)

github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(@aws-amplify/datastore): check read-only at instance level #8794

fix(@aws-amplify/datastore): check read-only at instance level #8794

iartemiev commented Aug 23, 2021

nickarocho left a comment

nickarocho Aug 23, 2021

nickarocho Aug 23, 2021

github-actions bot commented Aug 25, 2022

fix(@aws-amplify/datastore): check read-only at instance level #8794

fix(@aws-amplify/datastore): check read-only at instance level #8794

Conversation

iartemiev commented Aug 23, 2021

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

nickarocho left a comment

Choose a reason for hiding this comment

nickarocho Aug 23, 2021

Choose a reason for hiding this comment

nickarocho Aug 23, 2021

Choose a reason for hiding this comment

github-actions bot commented Aug 25, 2022