Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@aws-amplify/ui-components): Update injectGlobalPaths #8994

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Oct 5, 2021

Description of changes

Reflecting changes from ionic-team/stencil-sass@b1cc372, this array needs to be structured like so in the file changed. Should fix yarn build issue that is currently ongoing on CI.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@wlee221
Copy link
Contributor Author

wlee221 commented Oct 5, 2021

I'll merge after build/unit tests pass

@codecov-commenter
Copy link

Codecov Report

Merging #8994 (05c581a) into main (bd528c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8994   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files         246      246           
  Lines       17670    17670           
  Branches     3798     3798           
=======================================
  Hits        13795    13795           
  Misses       3746     3746           
  Partials      129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd528c7...05c581a. Read the comment docs.

@wlee221 wlee221 merged commit f8b1061 into main Oct 5, 2021
wlee221 added a commit that referenced this pull request Oct 12, 2021
wlee221 added a commit that referenced this pull request Oct 12, 2021
…n @stencil/sass (#9021)

* Revert "chore(@aws-amplify/ui-components): Update injectGlobalPaths (#8994)"

This reverts commit f8b1061.

* Update package.json
@wlee221 wlee221 mentioned this pull request Dec 6, 2021
4 tasks
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2022
@jimblanc jimblanc deleted the update-global-inject-path branch November 23, 2022 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants