Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@aws-amplify/ui-components): reflect injectGlobalPaths revert on @stencil/sass #9021

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Oct 12, 2021

@stencil/sass reverted this change -- ionic-team/stencil-sass@7871073.

Also pinning @stencil/sass version to make sure this doesn't happen again.

@wlee221 wlee221 changed the title chore(@aws-amplify/ui-components): Flatten injectGlobalPaths array chore(@aws-amplify/ui-components): reflect injectGlobalPaths revert on @stencil/sass Oct 12, 2021
@wlee221 wlee221 marked this pull request as ready for review October 12, 2021 17:39
Copy link
Contributor

@ashika01 ashika01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wlee221
Copy link
Contributor Author

wlee221 commented Oct 12, 2021

image
Unit test passed locally, merging it in.

@wlee221 wlee221 merged commit 43383e5 into main Oct 12, 2021
@wlee221 wlee221 mentioned this pull request Dec 6, 2021
4 tasks
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
@jimblanc jimblanc deleted the revert-8994-update-global-inject-path branch November 23, 2022 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants