Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(in-app-messaging): version bump #9928

Conversation

calebpollman
Copy link
Contributor

@calebpollman calebpollman commented May 23, 2022

Description of changes

Increment notifications and aws-amplify-react-native versions and update used internal dep versions for tagged branch release

Issue #, if available

NA

Description of how you validated changes

yarn clean && yarn && yarn build

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested review from nickarocho and a team as code owners May 23, 2022 17:56
@codecov-commenter
Copy link

Codecov Report

Merging #9928 (28eec30) into in-app-messaging/main (887aab1) will increase coverage by 1.09%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##           in-app-messaging/main    #9928      +/-   ##
=========================================================
+ Coverage                  78.19%   79.29%   +1.09%     
=========================================================
  Files                        250      327      +77     
  Lines                      18185    20657    +2472     
  Branches                    3900     4509     +609     
=========================================================
+ Hits                       14220    16379    +2159     
- Misses                      3835     4172     +337     
+ Partials                     130      106      -24     
Impacted Files Coverage Δ
packages/geo/src/Geo.ts 81.63% <0.00%> (-10.04%) ⬇️
...ackages/pubsub/src/Providers/MqttOverWSProvider.ts 93.67% <0.00%> (-3.00%) ⬇️
...geo/src/Providers/AmazonLocationServiceProvider.ts 93.92% <0.00%> (-2.23%) ⬇️
packages/api-graphql/src/GraphQLAPI.ts 87.50% <0.00%> (-0.90%) ⬇️
packages/api-rest/src/RestAPI.ts 95.34% <0.00%> (-0.72%) ⬇️
packages/api-rest/src/RestClient.ts 94.00% <0.00%> (-0.60%) ⬇️
packages/auth/src/Auth.ts 86.80% <0.00%> (-0.24%) ⬇️
packages/pushnotification/src/PushNotification.ts 49.07% <0.00%> (-0.24%) ⬇️
packages/core/src/Hub.ts 85.00% <0.00%> (-0.19%) ⬇️
packages/core/src/constants.ts 100.00% <0.00%> (ø)
... and 139 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@nickarocho nickarocho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Synced offline with @calebpollman re: bumping versions in this branch, I thought Lerna handled auto bumping, but not on this branch 👍

@calebpollman calebpollman merged commit 3322097 into aws-amplify:in-app-messaging/main May 23, 2022
@calebpollman calebpollman deleted the in-app-messaging/version-bump branch May 23, 2022 18:42
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server amplify-help forum.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants