Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AWSS3StoragePlugin framework and AmplifyAppExample and podspecs #1

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

lawmicha
Copy link
Member

@lawmicha lawmicha commented Aug 19, 2019

Issue #, if available:

Description of changes:

  • Adding AWSS3StoragePlugin framework target to workspace
    -- skeleton code to begin adding implementation details
  • Adding AmplifyAppExample App target
    -- useful for testing exposed functionality from the frameworks and running app with Amplify and plugin end-to-end
  • Adding podspec for Amplify and AWSS3StoragePlugin
    -- useful for creating new App outside of the workspace to consume pods locally on desktop, ie. for an App with the same level as amplify repo, podfile is
    # Pods for AmplifyOutsideTestApp
    pod 'Amplify', :path => '../amplify-ios'
    pod 'AWSS3StoragePlugin', :path => '../amplify-ios'

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from palpatim August 19, 2019 17:50
Copy link
Member

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as WIP

@palpatim palpatim merged commit dbb9df5 into palpatim/wip Aug 21, 2019
@bfallon bfallon mentioned this pull request Mar 5, 2024
waleedbutt pushed a commit to hassan31/amplify-swift that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants