fix(v1): CPK has-many has-one associatedFields

[lawmicha]

Issue #

Table of contents

• Library Changes data-dev-preview fix: CPK uni-directional has-many lazy list load #2730
• Library Changes v1 - fix(v1): CPK has-many has-one associatedFields #2734 (You are here)
• Library Changes main - fix: CPK has-many has-one associatedFields #2735
• Codegen Changes - fix(amplify-codegen): swift - add has-many associatedFields for CPK use case amplify-codegen#538
• Codegen Changes has-one - [DO-NOT-MERGE] fix(amplify-codegen): swift - add has-one associatedFields for CPK use case amplify-codegen#541

Description

This PR does not attempt to fix the uni-directional has-many lazy loading list issue, see #2730 for more details and the fix. Since the CPK codegen changes (aws-amplify/amplify-codegen#538 ) are available in v1, this PR introduces that parameter to make sure newly generated types continue to compile with the added associatedWithFields argument to hasMany model fields. When we are ready to move forward with the backport of #2711 then it will be solved on v1.

We are also fixing uni-directional has-one CPK use case by extending has-one with `associatedFields. Corresponding codegen changes are in aws-amplify/amplify-codegen#541

General Checklist

• Added new tests to cover change, if needed
• Build succeeds with all target using Swift Package Manager
• All unit tests pass
• All integration tests pass
• Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
• Documentation update for the change if required
• PR title conforms to conventional commit style
• New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
• If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

Merging #2734 (fe29459) into v1 (9bf836c) will decrease coverage by 0.15%.
The diff coverage is 48.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##               v1    #2734      +/-   ##
==========================================
- Coverage   64.42%   64.28%   -0.15%     
==========================================
  Files         720      720              
  Lines       22722    22736      +14     
==========================================
- Hits        14639    14616      -23     
- Misses       8083     8120      +37     

Flag	Coverage Δ
API_plugin_unit_test	66.78% <ø> (ø)
AWSPluginsCore	73.27% <100.00%> (-0.08%)	⬇️
Amplify	51.27% <42.30%> (-0.10%)	⬇️
Analytics_plugin_unit_test	72.43% <ø> (ø)
Auth_plugin_unit_test	83.88% <ø> (ø)
DataStore_plugin_unit_test	81.67% <100.00%> (-0.40%)	⬇️
Geo_plugin_unit_test	57.87% <ø> (ø)
Predictions_plugin_unit_test	33.61% <ø> (ø)
Storage_plugin_unit_test	59.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...Model/Internal/Schema/ModelSchema+Definition.swift	55.90% <0.00%> (-5.75%)	⬇️
...Model/Internal/Schema/ModelField+Association.swift	46.93% <100.00%> (+3.50%)	⬆️
...e/AWSPluginsCore/Model/Support/Model+GraphQL.swift	74.80% <100.00%> (ø)
...insCore/Model/Support/QueryPredicate+GraphQL.swift	74.63% <100.00%> (ø)
...goryPlugin/Storage/SQLite/ModelSchema+SQLite.swift	94.25% <100.00%> (ø)
...ingMutationQueue/OutgoingMutationQueue+State.swift	0.00% <0.00%> (-68.75%)	⬇️
...ngMutationQueue/OutgoingMutationQueue+Action.swift	0.00% <0.00%> (-66.67%)	⬇️
...e/AWSPluginsCore/Auth/AWSAuthServiceBehavior.swift	75.00% <0.00%> (-12.50%)	⬇️
...MutationQueue/OutgoingMutationQueue+Resolver.swift	82.14% <0.00%> (-10.72%)	⬇️
...s/AWSHubPlugin/Internal/HubChannelDispatcher.swift	94.11% <0.00%> (-2.95%)	⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[5d]

LGTM