fix: CPK has-many has-one associatedFields #2735
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Table of contents
data-dev-preview
fix: CPK uni-directional has-many lazy list load #2730v1
- fix(v1): CPK has-many has-one associatedFields #2734main
- fix: CPK has-many has-one associatedFields #2735 (You are here)Description
This PR does not attempt to fix the uni-directional has-many lazy loading list issue, see #2730 for more details and the fix. Since the CPK codegen changes (aws-amplify/amplify-codegen#538 ) are available in
main
, this PR introduces that parameter to make sure newly generated types continue to compile with the addedassociatedWithFields
argument to hasMany model fields. When we are ready to move forward the lazy loading feature branch #2658 , the fix will be included as wellWe are also fixing uni-directional has-one CPK use case by extending has-one with
associatedFields
. Corresponding codegen changes are in aws-amplify/amplify-codegen#541General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.