Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump swift sdk to 0.26.1 #3333

Merged
merged 1 commit into from Oct 31, 2023
Merged

fix: bump swift sdk to 0.26.1 #3333

merged 1 commit into from Oct 31, 2023

Conversation

atierian
Copy link
Member

@atierian atierian commented Oct 31, 2023

Issue #

Description

Bumps AWS SDK for Swift from 0.26.0 to 0.26.1.

0.26.1 pins aws-crt-swift 0.17.0, which puts the common_cryptor_spi.h behind an #ifdef directive to prevent the non-public symbols from being included in release builds.

This fix was confirmed through manual testing - uploading an app to App Store Connect that embeds a .framework, which wraps Amplify Swift + plugin targets.

In addition to confirming that the upload to App Store Connect succeeded, the non-public CCCryptorGCM... symbols were confirmed to not be included in release build artifacts.

Prior to Change / Before

> nm -m <archive-path>.xcarchive/Products/Applications/my_app.app/Frameworks/wrapper.framework/wrapper | grep CCCryptorGC
                 U _CCCryptorGCMAddAAD
                 U _CCCryptorGCMFinalize
                 U _CCCryptorGCMSetIV

> dwarfdump <archive-path>.xcarchive/dSYMs/wrapper.framework.dSYM | grep CCCryptorGCM -A 1
                DW_AT_name	("CCCryptorGCMSetIV")
                DW_AT_decl_file	("/.../checkouts/aws-crt-swift/aws-common-runtime/aws-c-cal/source/darwin/common_cryptor_spi.h")
--
                DW_AT_name	("CCCryptorGCMAddAAD")
                DW_AT_decl_file	("/.../checkouts/aws-crt-swift/aws-common-runtime/aws-c-cal/source/darwin/common_cryptor_spi.h")
--
                DW_AT_name	("CCCryptorGCMFinalize")
                DW_AT_decl_file	("/.../checkouts/aws-crt-swift/aws-common-runtime/aws-c-cal/source/darwin/common_cryptor_spi.h")

With Change / Now

> nm -m <archive-path>.xcarchive/Products/Applications/my_app.app/Frameworks/wrapper.framework/wrapper | grep CCCryptorGC
# no results

> dwarfdump <archive-path>.xcarchive/dSYMs/wrapper.framework.dSYM | grep CCCryptorGCM -A 1
# no results

Relevant Links

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian marked this pull request as ready for review October 31, 2023 14:34
@atierian atierian requested a review from a team as a code owner October 31, 2023 14:34
@phantumcode phantumcode merged commit 518a093 into main Oct 31, 2023
77 checks passed
@phantumcode phantumcode deleted the sdk-minor-bump branch October 31, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants