Stop using private CommonCrypto APIs on iOS #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMusatkin
approved these changes
Oct 30, 2023
graebm
added a commit
to awslabs/aws-crt-swift
that referenced
this pull request
Oct 30, 2023
Update all submodules to latest, the fix comes from: awslabs/aws-c-cal#170 aws-c-auth v0.7.4 -> v0.7.5 aws-c-cal v0.6.7 -> v0.6.8 aws-c-common v0.9.4 -> v0.9.5
This was referenced Oct 30, 2023
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
App Store submissions are being rejected due to use of non-public CommonCrypto functions for doing AES GCM:
There are no public APIs for doing AES GCM via CommonCrypto
Description of changes:
Remove the code for doing AES GCM (via non-public CommonCrypto functions) on iOS, watchOS, etc
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.