Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update aws-swift-sdk dependency to 0.36.1 #3519

Merged
merged 23 commits into from
Feb 22, 2024
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Feb 14, 2024

Issue #

#3518 , #3486

Description

The PR is aimed at updating the aws-swift-sdk dependency to 0.36.1. https://github.com/awslabs/aws-sdk-swift/releases/tag/0.36.1. Updating to this release has triggered several changes that need to be made in Amplify. The changes are as follows:

  • Renaming HttpClientEngine -> HTTPClient
  • Renaming HTTPClient (originally HttpClientEngine) protocol method from execute to send
  • Migrating using HTTPBody to ByteStream from ClientRuntime
  • Renaming ClientRuntime.URLQueryItem -> ClientRuntime.SDKURLQueryItem
  • Removing the HTTP Client Engine override, since now aws-swift-sdk defaults to using Foundation API's. Important thing to note is that even though the override has been removed, the logic for the override is still in place. It was not removed, because the logic gives us a powerful method to switch/override HTTP clients from the SDK, in future or in testing.
  • Since the SDK now now eliminated service client protocols and Amplify was relying heavily on it, we have mimicked the SDK implementation to keep using the protocol structure. (feat!: Eliminate service client protocols awslabs/aws-sdk-swift#1322)
  • Updated integration and unit tests

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
    Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@ruisebas ruisebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@harsh62 harsh62 merged commit 301b332 into main Feb 22, 2024
121 of 122 checks passed
@harsh62 harsh62 deleted the swift-sdk-update branch February 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants