-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update aws-swift-sdk dependency to 0.36.1 #3519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#3518 , #3486
Description
The PR is aimed at updating the
aws-swift-sdk
dependency to0.36.1
. https://github.com/awslabs/aws-sdk-swift/releases/tag/0.36.1. Updating to this release has triggered several changes that need to be made in Amplify. The changes are as follows:HttpClientEngine
->HTTPClient
HTTPClient
(originallyHttpClientEngine
) protocol method fromexecute
tosend
HTTPBody
toByteStream
from ClientRuntimeClientRuntime.URLQueryItem
->ClientRuntime.SDKURLQueryItem
aws-swift-sdk
defaults to using Foundation API's. Important thing to note is that even though the override has been removed, the logic for the override is still in place. It was not removed, because the logic gives us a powerful method to switch/override HTTP clients from the SDK, in future or in testing.General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.