Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): use custom HTTPClient for HTTP Requests #3582

Merged
merged 3 commits into from
May 3, 2024

Conversation

thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Mar 22, 2024

Issue #

In #3519, we upgraded aws-sdk-swift dependency to 0.36.1 and removed our custom http client engine to use aws-sdk-swift HTTP Client for making HTTP requests. This is causing latency increase in release/production builds for customers when making Auth category API calls(fetchAuthSession()/signIn()). This was released in 2.27.0.

Description

This PR reverts the change to use our custom HTTP Client which was used in 2.26.3 where the customer has confirmed that they are not experiencing the issue.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner March 22, 2024 21:23
@thisisabhash
Copy link
Member Author

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 68.20%. Comparing base (295521f) to head (cb2da44).
Report is 8 commits behind head on main.

Files Patch % Lines
...HttpClientEngine/FoundationClientEngineError.swift 0.00% 44 Missing ⚠️
...tpClientEngine/ClientRuntimeFoundationBridge.swift 0.00% 30 Missing ⚠️
...ustomHttpClientEngine/FoundationClientEngine.swift 0.00% 15 Missing ⚠️
...ls/CustomHttpClientEngine/PluginClientEngine.swift 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
- Coverage   68.42%   68.20%   -0.23%     
==========================================
  Files        1077     1087      +10     
  Lines       36294    37043     +749     
==========================================
+ Hits        24835    25264     +429     
- Misses      11459    11779     +320     
Flag Coverage Δ
API_plugin_unit_test 67.79% <ø> (+0.29%) ⬆️
AWSPluginsCore 66.27% <0.00%> (-0.63%) ⬇️
Amplify 48.21% <ø> (+0.11%) ⬆️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.01% <ø> (-0.04%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.33% <ø> (-1.04%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.10% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.65% <ø> (+0.03%) ⬆️
unit_tests 68.20% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruisebas ruisebas dismissed stale reviews from harsh62, lawmicha, and themself via 0ed06f9 May 3, 2024 19:46
@ruisebas ruisebas merged commit 89abfcd into main May 3, 2024
94 checks passed
@ruisebas ruisebas deleted the fix/revert-http-client branch May 3, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants