feat(predictions): add implementation for no light support #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantumcode
reviewed
Apr 17, 2024
...ifyPlugins/Predictions/AWSPredictionsPlugin/Liveness/Events/LivenessInitialClientEvent.swift
Outdated
Show resolved
Hide resolved
phantumcode
reviewed
Apr 17, 2024
...ifyPlugins/Predictions/AWSPredictionsPlugin/Liveness/SPI/AWSPredictionsPlugin+Liveness.swift
Outdated
Show resolved
Hide resolved
phantumcode
reviewed
Apr 17, 2024
AmplifyPlugins/Predictions/AWSPredictionsPlugin/Liveness/SPI/LivenessStreamingURL.swift
Outdated
Show resolved
Hide resolved
phantumcode
reviewed
Apr 17, 2024
AmplifyPlugins/Predictions/AWSPredictionsPlugin/Liveness/Service/FaceLivenessSession.swift
Outdated
Show resolved
Hide resolved
phantumcode
reviewed
Apr 17, 2024
| components?.queryItems = [ | ||
| URLQueryItem(name: "session-id", value: sessionID), | ||
| URLQueryItem(name: "challenge-versions", value: "FaceMovementAndLightChallenge_1.0.0"), | ||
| URLQueryItem(name: "precheck-view-enabled", value: options.preCheckViewEnabled ? "1":"0"), | ||
| URLQueryItem(name: "attempt-id", value: options.viewId), |
There was a problem hiding this comment.
should attempt-id get changed to view-id?
There was a problem hiding this comment.
added a Todo to revisit this - pending confirmation
phantumcode
reviewed
Apr 17, 2024
AmplifyPlugins/Predictions/AWSPredictionsPlugin/Liveness/ServiceModel/ServerChallenge.swift
Outdated
Show resolved
Hide resolved
phantumcode
reviewed
Apr 17, 2024
AmplifyPlugins/Predictions/AWSPredictionsPlugin/Liveness/ServiceModel/ServerChallenge.swift
Outdated
Show resolved
Hide resolved
phantumcode
approved these changes
Apr 17, 2024
thisisabhash
added a commit
that referenced
this pull request
Apr 17, 2024
…ort (#3617) * feat(predictions): add public definitions for no light challenge support * Add missing files * fix swiftlint issue * feat(predictions): add implementation for no light support (#3618) * feat(predictions): add implementation for no light support * fix swiftlint issue * address review comments * address review comments * address review comments
thisisabhash
added a commit
that referenced
this pull request
May 7, 2024
…ort (#3617) * feat(predictions): add public definitions for no light challenge support * Add missing files * fix swiftlint issue * feat(predictions): add implementation for no light support (#3618) * feat(predictions): add implementation for no light support * fix swiftlint issue * address review comments * address review comments * address review comments
thisisabhash
added a commit
that referenced
this pull request
Jul 1, 2024
…ort (#3617) * feat(predictions): add public definitions for no light challenge support * Add missing files * fix swiftlint issue * feat(predictions): add implementation for no light support (#3618) * feat(predictions): add implementation for no light support * fix swiftlint issue * address review comments * address review comments * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
None
Description
Add implementation for no light support
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.