Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(predictions): add public definitions for no light challenge support #3617

Merged
merged 4 commits into from
Apr 17, 2024
Merged

feat(predictions): add public definitions for no light challenge support #3617

merged 4 commits into from
Apr 17, 2024

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

Add public definitions for no light challenge support

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner April 16, 2024 21:03
@thisisabhash
feat(predictions): add implementation for no light support (#3618)
0148783 
* feat(predictions): add implementation for no light support

* fix swiftlint issue

* address review comments

* address review comments

* address review comments
@thisisabhash thisisabhash merged commit 7c1fa2f into feat/no-light-support Apr 17, 2024
74 checks passed
@thisisabhash thisisabhash deleted the add-public-defs branch April 17, 2024 22:46
thisisabhash added a commit that referenced this pull request May 7, 2024
@thisisabhash
feat(predictions): add public definitions for no light challenge supp…
afdf3a5 
…ort (#3617)

* feat(predictions): add public definitions for no light challenge support

* Add missing files

* fix swiftlint issue

* feat(predictions): add implementation for no light support (#3618)

* feat(predictions): add implementation for no light support

* fix swiftlint issue

* address review comments

* address review comments

* address review comments
thisisabhash added a commit that referenced this pull request Jul 1, 2024
@thisisabhash
feat(predictions): add public definitions for no light challenge supp…
02328ae 
…ort (#3617)

* feat(predictions): add public definitions for no light challenge support

* Add missing files

* fix swiftlint issue

* feat(predictions): add implementation for no light support (#3618)

* feat(predictions): add implementation for no light support

* fix swiftlint issue

* address review comments

* address review comments

* address review comments
thisisabhash added a commit that referenced this pull request Aug 22, 2024
@thisisabhash
feat(predictions): add public definitions for no light challenge supp…
15489e7 
…ort (#3617)

* feat(predictions): add public definitions for no light challenge support

* Add missing files

* fix swiftlint issue

* feat(predictions): add implementation for no light support (#3618)

* feat(predictions): add implementation for no light support

* fix swiftlint issue

* address review comments

* address review comments

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantumcode phantumcode phantumcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisabhash @phantumcode