-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to latest maplibre-gl-js-amplify for maplibre v2 support #2263
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@aws-amplify/ui-react': patch | ||
--- | ||
|
||
Update to latest version of maplibre-gl-js-amplify to support maplibre-gl v2 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,8 +67,8 @@ | |
"deepmerge": "4.2.2", | ||
"lodash": "4.17.21", | ||
"mapbox-gl": "1.13.1", | ||
"maplibre-gl": "1.15.3", | ||
"maplibre-gl-js-amplify": "1.5.0", | ||
"maplibre-gl": "2.1.9", | ||
"maplibre-gl-js-amplify": "2.0.0", | ||
"qrcode": "1.5.0", | ||
"react-generate-context": "1.0.1", | ||
"react-map-gl": "7.0.15" | ||
|
@@ -134,7 +134,7 @@ | |
"name": "Geo", | ||
"path": "dist/esm/index.js", | ||
"import": "{ MapView, LocationSearch }", | ||
"limit": "300 kB" | ||
"limit": "330 kB" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure we're OK with bumping this limit given this is a jump from 280kB to 330kB, or about an 11.5% jump for an app bundle using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How big is the bundle now? Exactly 330k? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's now: |
||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size increase is due to the addition of the Geofence feature in the upgraded
maplibre-gl-js-amplify
package.