Zero-config + Sign in with Apple #626

ericclemmons · 2021-11-03T20:19:52Z

Description of changes:

Updates authMachine to have both loginMechanisms and socialProviders based on new Amplify CLI zero-config aws-exports.js. (Closes Update examples to use zero-config #609)

This means that most usage will just be withAuthenticator or <Authenticator>!
Adds Sign in with Apple button (Closes Sign in with Apple #607)

apple.mp4
Fix React to use loginMechanisms and socialProviders
Fix Angular to use loginMechanisms and socialProviders
Fix Vue to use loginMechanisms and socialProviders

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

yarn global add @aws-amplify/cli@beta 6.5.0-beta.0

changeset-bot · 2021-11-03T20:19:57Z

🦋 Changeset detected

Latest commit: 122b146

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@aws-amplify/ui	Minor
@aws-amplify/ui-angular	Minor
@aws-amplify/ui-react	Minor
@aws-amplify/ui-vue	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lgtm-com · 2021-11-03T20:25:39Z

This pull request introduces 1 alert when merging 54fe748 into 391e2f3 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

ericclemmons

The primary change is that login_mechanisms has been split out into loginMechanisms (username, email, phone_number) and socialProviders based on the zero-config values.

ericclemmons · 2021-11-04T15:22:34Z

...derated/amplify/backend/auth/authwithfederated/authwithfederated-cloudformation-template.yml

@@ -1,3 +1,4 @@
+


Most of the environments/* updates are from yarn environments pull using the new CLI beta – 6.5.0-beta.0

ericclemmons · 2021-11-04T15:27:10Z

...onents/authenticator/components/amplify-confirm-sign-up/amplify-confirm-sign-up.component.ts

-    const actorState: SignUpState = getActorState(state);
+    const actorState = getActorState(state) as SignUpState;


These assignments were getting errors only in Angular. I think there's an opportunity for types to get cleaned up to prevent as casting:

…o-config

https://docs.amplify.aws/cli/migration/cli-auth-signup-changes/

ericclemmons · 2021-11-05T18:01:14Z

@ErikCH found the issue! https://github.com/aws-amplify/amplify-ui/tree/main/environments/auth-with-totp-mfa is an imported Cognito User Pool, so it isn't getting the zero-config values correctly like others:

// aws-exports.js
/* eslint-disable */
// WARNING: DO NOT EDIT. This file is automatically generated by AWS Amplify. It will be overwritten.

const awsmobile = {
    "aws_project_region": "us-east-1",
    "aws_cognito_region": "us-east-1",
    "aws_user_pools_id": "us-east-1_•••••",
    "aws_user_pools_web_client_id": "•••••",
    "oauth": {},
    "aws_cognito_username_attributes": [],
    "aws_cognito_social_providers": [],
    "aws_cognito_signup_attributes": [],
    "aws_cognito_mfa_configuration": "ON",
    "aws_cognito_mfa_types": [],
    "aws_cognito_password_protection_settings": {
        "passwordPolicyCharacters": []
    },
    "aws_cognito_verification_mechanisms": []
};


export default awsmobile;

Notice how aws_cognito_username_attributes is empty, so owe default to ['username'].

@lazpavel What's your take on it?

Imported environments don't work with zero-config (yet): #626 (comment)

…nto 609-zero-config

ericclemmons · 2021-11-05T20:40:17Z

I introduced a new adminui-auth-with-totp-mfa (2c84a18) for our e2e test until the issue in #626 (comment) is resolved.

lgtm-com · 2021-11-05T20:49:21Z

This pull request introduces 4 alerts and fixes 2 when merging 9fd0972 into 6c57ef8 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class

fixed alerts:

2 for Unused variable, import, function or class

ErikCH · 2021-11-05T21:08:21Z

packages/ui/src/machines/authenticator/index.ts

+            // Prefer explicitly configured settings over default CLI values
+            return {
+              loginMechanisms: loginMechanisms ?? cliLoginMechanisms,
+              socialProviders: socialProviders ?? cliSocialProviders.sort(),
+            };


Nice, understood

ErikCH

Looking at the Vue changes, and overall looks good. But I'll refer to @wlee221 expertise in the other areas and Angular

wlee221

LGTM 🚢

Fixes #605

lgtm-com · 2021-11-08T17:57:14Z

This pull request introduces 4 alerts and fixes 2 when merging 52d7fe1 into d71e656 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class

fixed alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-11-08T18:13:09Z

This pull request introduces 4 alerts and fixes 2 when merging 122b146 into d71e656 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class

fixed alerts:

2 for Unused variable, import, function or class

ericclemmons added 6 commits November 3, 2021 13:48

Update backends to be zero-config

562ba6e

yarn global add @aws-amplify/cli@beta 6.5.0-beta.0

Update sign-in-federate.feature to include Apple

116c161

Authenticator splits into loginMechanisms & socialProviders

f26e8ec

Update FormFields to use loginMechanisms

cdbdede

Pass socialProviders & loginMechanisms through withAuthenticator

7bf1796

Add Sign in with Apple button

54fe748

ericclemmons added 4 commits November 4, 2021 10:02

Fix Angular build

ebc430b

Fix Vue build

eb9d7d7

Remove unused imports

6c6f4cd

Add note that environments require @aws-amplify/cli@6.5.0-beta.0

feadd5f

ericclemmons commented Nov 4, 2021

View reviewed changes

ericclemmons added 6 commits November 4, 2021 10:39

Add loginMechanisms & socialProviders to SignInContext

c6e8cb1

Explicitly cast actorContext as ActorContextWithForms

b4111d5

Fix Angular by explicitly casting to expected state/context

26b1025

Fix Vue build by explicitly casting SignInState

c7e776d

Merge branch 'main' of github.com:aws-amplify/amplify-ui into 609-zer…

fe6b272

…o-config

Fix React linting

ee4321a

ericclemmons had a problem deploying to ci November 4, 2021 17:47 Error

ericclemmons had a problem deploying to ci November 4, 2021 17:47 Failure

ericclemmons had a problem deploying to ci November 4, 2021 17:47 Error

ericclemmons added 3 commits November 4, 2021 13:34

Remove loginMechanisms from React examples

568d82d

Remove auth-with-multi-alias support

2f86770

https://docs.amplify.aws/cli/migration/cli-auth-signup-changes/

Merge branch 'main' into 609-zero-config

acb718e

ericclemmons force-pushed the 609-zero-config branch from c0f1baa to acb718e Compare November 4, 2021 19:53

Deprecate auth-with-multi-alias backend

ce8140b

ericclemmons had a problem deploying to ci November 4, 2021 20:02 Error

Add Sign In with Apple button for Vue

b7ef5c4

ericclemmons had a problem deploying to ci November 4, 2021 20:02 Error

ericclemmons marked this pull request as ready for review November 5, 2021 16:59

ericclemmons added 4 commits November 5, 2021 15:37

Use adminui-auth-with-totp-mfa for e2e testing

2c84a18

Imported environments don't work with zero-config (yet): #626 (comment)

Make QR Code 228x228 so it doesn't blur-up

b3377ac

Add TODOs around zero-config

d5809af

Merge branch '609-zero-config' of github.com:aws-amplify/amplify-ui i…

9fd0972

…nto 609-zero-config

ericclemmons temporarily deployed to ci November 5, 2021 20:48 Inactive

ErikCH reviewed Nov 5, 2021

View reviewed changes

ErikCH approved these changes Nov 5, 2021

View reviewed changes

wlee221 approved these changes Nov 8, 2021

View reviewed changes

ericclemmons added 2 commits November 8, 2021 11:51

Add zero-configuration documentation

8b556b9

Fix automatic linking of headers to support #hash

52d7fe1

Fixes #605

ericclemmons temporarily deployed to ci November 8, 2021 18:01 Inactive

Create cold-tips-yawn.md

122b146

ericclemmons temporarily deployed to ci November 8, 2021 18:18 Inactive

ericclemmons merged commit f84e994 into main Nov 8, 2021

ericclemmons deleted the 609-zero-config branch November 8, 2021 18:39

github-actions bot mentioned this pull request Nov 8, 2021

Version Packages #596

Merged

ericclemmons mentioned this pull request Nov 8, 2021

Docs Site Header links go to 404 #605

Closed

thaddmt added a commit that referenced this pull request Apr 7, 2023

fix: added camera permission retry CTA (#626)

4945040

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zero-config + Sign in with Apple #626

Zero-config + Sign in with Apple #626

ericclemmons commented Nov 3, 2021 •

edited

Loading

changeset-bot bot commented Nov 3, 2021 •

edited

Loading

lgtm-com bot commented Nov 3, 2021

ericclemmons left a comment

ericclemmons Nov 4, 2021

ericclemmons Nov 4, 2021

ericclemmons commented Nov 5, 2021

ericclemmons commented Nov 5, 2021 •

edited

Loading

lgtm-com bot commented Nov 5, 2021

ErikCH Nov 5, 2021

ErikCH left a comment

wlee221 left a comment

lgtm-com bot commented Nov 8, 2021

lgtm-com bot commented Nov 8, 2021

		const actorState: SignUpState = getActorState(state);
		const actorState = getActorState(state) as SignUpState;

Zero-config + Sign in with Apple #626

Zero-config + Sign in with Apple #626

Conversation

ericclemmons commented Nov 3, 2021 • edited Loading

changeset-bot bot commented Nov 3, 2021 • edited Loading

🦋 Changeset detected

lgtm-com bot commented Nov 3, 2021

ericclemmons left a comment

Choose a reason for hiding this comment

ericclemmons Nov 4, 2021

Choose a reason for hiding this comment

ericclemmons Nov 4, 2021

Choose a reason for hiding this comment

ericclemmons commented Nov 5, 2021

ericclemmons commented Nov 5, 2021 • edited Loading

lgtm-com bot commented Nov 5, 2021

ErikCH Nov 5, 2021

Choose a reason for hiding this comment

ErikCH left a comment

Choose a reason for hiding this comment

wlee221 left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Nov 8, 2021

lgtm-com bot commented Nov 8, 2021

ericclemmons commented Nov 3, 2021 •

edited

Loading

changeset-bot bot commented Nov 3, 2021 •

edited

Loading

ericclemmons commented Nov 5, 2021 •

edited

Loading